linux-kernel - Re: [PATCH v4 0/4] Add support for XP-PEN Deco L

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2206151552060.14340@cbobk.fhfr.pm>
Date:   Wed, 15 Jun 2022 15:52:27 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     José Expósito <jose.exposito89@...il.com>
cc:     benjamin.tissoires@...hat.com, spbnick@...il.com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        stefanberzl@...il.com, dlatypov@...gle.com,
        kunit-dev@...glegroups.com
Subject: Re: [PATCH v4 0/4] Add support for XP-PEN Deco L

On Sat, 11 Jun 2022, José Expósito wrote:

> Hello everyone,
> 
> This patchset adds support for the UGEE XP-PEN Deco L tablet.
> This device belongs to a family of tablets that must receive a chunk of
> magic data in order to be enabled (named UGEE v2 internally).
> 
> Once the device is enabled, its parameters can be discovered by parsing
> a report descriptor. HUION v1 tablets have a similar report descriptor
> but, in the case of UGEE v2 tablets, the number of buttons are also
> discoverable [1].
> 
> The ability to discover the number of buttons is the reason for the
> first 3 patches. They enable frame templates.
> Because I lack the hardware to fully test this driver, I added some
> KUnit tests to make sure no bugs are introduced.
> I didn't see any other test in the subsystem (and I doubt I'm the first
> person writing one) so please let me know if I need to move the test to
> a different place.
> 
> The last patch enables the tablet.
> 
> Best wishes,
> José Expósito
> 
> [1] I don't own a HUION v1 device, so I'm not sure if the information
>     about the number of buttons is also present and it is not used in
>     the driver for some reason.
> [2] https://lore.kernel.org/linux-input/20220516112159.GA74406@elementary/T/#t
> 
> ---
> 
> v1 - https://lore.kernel.org/linux-input/20220518224702.1409327-1-jose.exposito89@gmail.com/
> 
> v2 - https://lore.kernel.org/linux-input/20220518224702.1409327-1-jose.exposito89@gmail.com/T/
> 
>  - Add MODULE_DESCRIPTION/LICENSE/AUTHOR to hid-uclogic-rdesc-test.c
>  - Remove unused variable in uclogic_params_ugee_v2_init
>  - Add sparse __force anotation in the result of cpu_to_le16
>  - Add DISABLE_STRUCTLEAK_PLUGIN for KUnit tests
> 
> v3 - https://lore.kernel.org/linux-input/nycvar.YFH.7.76.2206081150060.10851@cbobk.fhfr.pm/T/
> 
>  - Improve Kconfig message
>  - Add .kunitconfig. Thanks to Daniel Latypov for suggesting it in an
>    unrelated patch:
>    https://lore.kernel.org/dri-devel/CAGS_qxpV2SsihEdgXZ6+7N0dxLmdRANq+qE4iUZ2aNrf6vuLYg@mail.gmail.com/
> 
> v4:
> 
>  - Group all the test of the subsystem under HID_KUNIT_TEST:
>    HID_UCLOGIC_KUNIT_TEST -> HID_KUNIT_TEST
>  - Remove DISABLE_STRUCTLEAK_PLUGIN:
>    https://lore.kernel.org/dri-devel/CAGS_qxpFO4ixW=08ZcdcD9J1kU=B3mwoBJkPW8AKu0sKs8aKfA@mail.gmail.com/
> 

Now in hid.git#for-5.20/uclogic. Thanks,

-- 
Jiri Kosina
SUSE Labs