linux-kernel - Re: [PATCH v4] soc: nuvoton: Add SoC info driver for WPCM450

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Jun 2022 16:00:17 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>
Cc:     OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        Joel Stanley <joel@....id.au>,
        Paul Menzel <pmenzel@...gen.mpg.de>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Lubomir Rintel <lkundrak@...sk>, Arnd Bergmann <arnd@...db.de>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Hector Martin <marcan@...can.st>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Sven Peter <sven@...npeter.dev>,
        Heiko Stuebner <heiko@...ech.de>,
        Brian Norris <briannorris@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] soc: nuvoton: Add SoC info driver for WPCM450

On Thu, Jun 9, 2022 at 11:35 PM Jonathan Neuschäfer
<j.neuschaefer@....net> wrote:
>
> Add a SoC information driver for Nuvoton WPCM450 SoCs. It provides
> information such as the SoC revision.
>
> Usage example:
>
>   # grep . /sys/devices/soc0/*
>   /sys/devices/soc0/family:Nuvoton NPCM
>   /sys/devices/soc0/revision:A3
>   /sys/devices/soc0/soc_id:WPCM450
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> Reviewed-by: Joel Stanley <joel@....id.au>
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>

Looks good overall.

> +menuconfig WPCM450_SOC
> +       bool "Nuvoton WPCM450 SoC driver"
> +       default y if ARCH_WPCM450

It would be nice to make this a tristate option, as we generally
like to keep optional drivers out of the allmodconfig vmlinux file,
even if this is a tiny one.

Just add the trivial cleanup function and MODULE_LICENSE() etc tags.

        Arnd