linux-kernel - Re: [External] Re: [PATCH] sched/fair: update comments in enqueue/dequeue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <afaeed75-cb46-0551-74c5-ebe29a26ba16@bytedance.com>
Date:   Wed, 15 Jun 2022 22:41:05 +0800
From:   Chengming Zhou <zhouchengming@...edance.com>
To:     peterz@...radead.org
Cc:     Vincent Guittot <vincent.guittot@...aro.org>, mingo@...hat.com,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [External] Re: [PATCH] sched/fair: update comments in
 enqueue/dequeue_entity()

On 2022/6/3 20:08, Vincent Guittot wrote:
> On Wed, 1 Jun 2022 at 05:55, Chengming Zhou <zhouchengming@...edance.com> wrote:
>>
>> When reading the sched_avg related code, I found the comments in
>> enqueue/dequeue_entity() are not updated with the current code.
>>
>> We don't add/subtract entity's runnable_avg from cfs_rq->runnable_avg
>> during enqueue/dequeue_entity(), those are done only for attach/detach.
>>
>> This patch updates the comments to reflect the current code working.
>>
>> Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>
> 
> Acked-by: Vincent Guittot <vincent.guittot@...aro.org>

Hello Peter, would you mind picking up this little patch too?

Thanks.

> 
>> ---
>>  kernel/sched/fair.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index b3371fa40548..e0cd4052e32f 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -4348,7 +4348,8 @@ enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags)
>>         /*
>>          * When enqueuing a sched_entity, we must:
>>          *   - Update loads to have both entity and cfs_rq synced with now.
>> -        *   - Add its load to cfs_rq->runnable_avg
>> +        *   - For group_entity, update its runnable_weight to reflect the new
>> +        *     h_nr_running of its group cfs_rq.
>>          *   - For group_entity, update its weight to reflect the new share of
>>          *     its group cfs_rq
>>          *   - Add its new weight to cfs_rq->load.weight
>> @@ -4433,7 +4434,8 @@ dequeue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags)
>>         /*
>>          * When dequeuing a sched_entity, we must:
>>          *   - Update loads to have both entity and cfs_rq synced with now.
>> -        *   - Subtract its load from the cfs_rq->runnable_avg.
>> +        *   - For group_entity, update its runnable_weight to reflect the new
>> +        *     h_nr_running of its group cfs_rq.
>>          *   - Subtract its previous weight from cfs_rq->load.weight.
>>          *   - For group entity, update its weight to reflect the new share
>>          *     of its group cfs_rq.
>> --
>> 2.36.1
>>