linux-kernel - Re: [PATCH] arch: x86: kernel: Add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Jun 2022 08:33:17 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Liang He <windhl@....com>, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
        hpa@...or.com, robh@...nel.org, frank.rowand@...y.com,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch: x86: kernel: Add missing of_node_put() in
 devicetree.c

On 6/15/22 08:03, Liang He wrote:
> In dtb_setup_hpet(), of_find_compatible_node() will return a node
> pointer with refcount incremented. We should use of_node_put() when it
> is not used anymore.
> 
> Signed-off-by: Liang He <windhl@....com>

Seems like:

Fixes: ffb9fc68dff3 ("x86: dtb: Add device tree support for HPET")

and would be appropriate, right?

Also, how was this found, and what is the impact from not fixing it?
Was it causing horrible problems in production, or was it just something
that was found by inspection that's not causing any real problems in
practice?