linux-kernel - Re: [PATCH] perf test: Add ARM SPE system wide test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Jun 2022 09:43:36 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     German Gomez <german.gomez@....com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ian Rogers <irogers@...gle.com>,
        linux-perf-users <linux-perf-users@...r.kernel.org>,
        John Garry <john.garry@...wei.com>,
        Will Deacon <will@...nel.org>,
        James Clark <james.clark@....com>,
        Mike Leach <mike.leach@...aro.org>,
        Leo Yan <leo.yan@...aro.org>
Subject: Re: [PATCH] perf test: Add ARM SPE system wide test

Hello,

On Thu, Jun 16, 2022 at 3:12 AM German Gomez <german.gomez@....com> wrote:
>
> Thanks for the patch, Namhyung
>
> On 15/06/2022 20:07, Namhyung Kim wrote:
> > In the past it had a problem not setting the pid/tid on the sample
> > correctly when system-wide mode is used.  Although it's fixed now it'd
> > be nice if we have a test case for it.
> >
> > Cc: German Gomez <german.gomez@....com>
> > Cc: Leo Yan <leo.yan@...aro.org>
> > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> > ---
> >  tools/perf/tests/shell/test_arm_spe.sh | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >
> > diff --git a/tools/perf/tests/shell/test_arm_spe.sh b/tools/perf/tests/shell/test_arm_spe.sh
> > index e59044edc406..b9c588ae393b 100755
> > --- a/tools/perf/tests/shell/test_arm_spe.sh
> > +++ b/tools/perf/tests/shell/test_arm_spe.sh
> > @@ -23,6 +23,7 @@ glb_err=0
> >  cleanup_files()
> >  {
> >       rm -f ${perfdata}
> > +     rm -f ${perfdata}.old
> >       exit $glb_err
> >  }
> >
> > @@ -85,5 +86,19 @@ arm_spe_snapshot_test() {
> >       arm_spe_report "SPE snapshot testing" $err
> >  }
> >
> > +arm_spe_system_wide_test() {
> > +     echo "Recording trace with system-wide mode $perfdata"
> > +     perf record -o ${perfdata} -e arm_spe// -a \
> > +             -- dd if=/dev/zero of=/dev/null count=100000 > /dev/null 2>&1
> > +
>
> Should we skip if we don't have privileges for CPU tracing? (attached diff)

Oh, you're right.  I'll squash it to the patch.

Thanks,
Namhyung


>
> > +     perf_script_samples dd &&
> > +     perf_report_samples dd
> > +
> > +     err=$?
> > +     arm_spe_report "SPE system-wide testing" $err
> > +}
> > +
> >  arm_spe_snapshot_test
> > +arm_spe_system_wide_test
> > +
> >  exit $glb_err