linux-kernel - Re: [PATCH] afs: Fix dynamic root getattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB9dFduhbTyC1_VLYH=Uz=W0JrpByHFzcb7p27_LuVxFA0yFiw@mail.gmail.com>
Date:   Thu, 16 Jun 2022 15:04:25 -0300
From:   Marc Dionne <marc.dionne@...istor.com>
To:     David Howells <dhowells@...hat.com>
Cc:     linux-afs@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] afs: Fix dynamic root getattr

On Wed, Jun 1, 2022 at 8:55 AM David Howells <dhowells@...hat.com> wrote:
>
> The recent patch to make afs_getattr consult the server didn't account for
> the pseudo-inodes employed by the dynamic root-type afs superblock not
> having a volume or a server to access, and thus an oops occurs if such a
> directory is stat'd.
>
> Fix this by checking to see if the vnode->volume pointer actually points
> anywhere before following it in afs_getattr().
>
> This can be tested by stat'ing a directory in /afs.  It may be sufficient
> just to do "ls /afs" and the oops looks something like:
>
>         BUG: kernel NULL pointer dereference, address: 0000000000000020
>         ...
>         RIP: 0010:afs_getattr+0x8b/0x14b
>         ...
>         Call Trace:
>          <TASK>
>          vfs_statx+0x79/0xf5
>          vfs_fstatat+0x49/0x62
>
> Fixes: 2aeb8c86d499 ("afs: Fix afs_getattr() to refetch file status if callback break occurred")
> Reported-by: Marc Dionne <marc.dionne@...istor.com>
> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: linux-afs@...ts.infradead.org
> ---
>
>  fs/afs/inode.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/afs/inode.c b/fs/afs/inode.c
> index 30b066299d39..33ecbfea0199 100644
> --- a/fs/afs/inode.c
> +++ b/fs/afs/inode.c
> @@ -745,7 +745,8 @@ int afs_getattr(struct user_namespace *mnt_userns, const struct path *path,
>
>         _enter("{ ino=%lu v=%u }", inode->i_ino, inode->i_generation);
>
> -       if (!(query_flags & AT_STATX_DONT_SYNC) &&
> +       if (vnode->volume &&
> +           !(query_flags & AT_STATX_DONT_SYNC) &&
>             !test_bit(AFS_VNODE_CB_PROMISED, &vnode->flags)) {
>                 key = afs_request_key(vnode->volume->cell);
>                 if (IS_ERR(key))

Reviewed-by: Marc Dionne <marc.dionne@...istor.com>
Tested-by: Marc Dionne <marc.dionne@...istor.com>

Marc