linux-kernel - Re: [PATCH] selftests dma: fix compile error for dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Jun 2022 14:05:48 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Yu Liao <liaoyu15@...wei.com>, chenxiang66@...ilicon.com,
        song.bao.hua@...ilicon.com, tiantao6@...ilicon.com,
        shuah@...nel.org
Cc:     liwei391@...wei.com, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests dma: fix compile error for dma_map_benchmark

On 6/14/22 6:02 AM, Yu Liao wrote:
> When building selftests/dma:
> $ make -C tools/testing/selftests TARGETS=dma
> I hit the following compilation error:
> 
> dma_map_benchmark.c:13:10: fatal error: linux/map_benchmark.h: No such file or directory
>   #include <linux/map_benchmark.h>
>            ^~~~~~~~~~~~~~~~~~~~~~~
> 
> dma/Makefile does not include the map_benchmark.h path, so add
> more including path, and fix include order in dma_map_benchmark.c
> 
> Fixes: 8ddde07a3d28 ("dma-mapping: benchmark: extract a common header file for map_benchmark definition")
> Signed-off-by: Yu Liao <liaoyu15@...wei.com>
> ---
>   tools/testing/selftests/dma/Makefile            | 1 +
>   tools/testing/selftests/dma/dma_map_benchmark.c | 2 +-
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/dma/Makefile b/tools/testing/selftests/dma/Makefile
> index aa8e8b5b3864..cd8c5ece1cba 100644
> --- a/tools/testing/selftests/dma/Makefile
> +++ b/tools/testing/selftests/dma/Makefile
> @@ -1,5 +1,6 @@
>   # SPDX-License-Identifier: GPL-2.0
>   CFLAGS += -I../../../../usr/include/
> +CFLAGS += -I../../../../include/
>   
>   TEST_GEN_PROGS := dma_map_benchmark
>   
> diff --git a/tools/testing/selftests/dma/dma_map_benchmark.c b/tools/testing/selftests/dma/dma_map_benchmark.c
> index c3b3c09e995e..5c997f17fcbd 100644
> --- a/tools/testing/selftests/dma/dma_map_benchmark.c
> +++ b/tools/testing/selftests/dma/dma_map_benchmark.c
> @@ -10,8 +10,8 @@
>   #include <unistd.h>
>   #include <sys/ioctl.h>
>   #include <sys/mman.h>
> -#include <linux/map_benchmark.h>
>   #include <linux/types.h>
> +#include <linux/map_benchmark.h>
>   
>   #define NSEC_PER_MSEC	1000000L
>   
> 

Thank you for the fix. Applied to linux-kselftest fixes branch for
Linux 5.19-rc3 or rc4

thanks,
-- Shuah