linux-kernel - Re: [PATCH v2 1/2] dt-bindings: dma: rework qcom,adm Documentation to yaml schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220616213200.GB3991754-robh@kernel.org>
Date:   Thu, 16 Jun 2022 15:32:00 -0600
From:   Rob Herring <robh@...nel.org>
To:     Christian Marangi <ansuelsmth@...il.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        dmaengine@...r.kernel.org, Vinod Koul <vkoul@...nel.org>,
        Andy Gross <agross@...nel.org>, linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: dma: rework qcom,adm Documentation
 to yaml schema

On Thu, Jun 16, 2022 at 04:02:34PM +0200, Christian Marangi wrote:
> On Thu, Jun 16, 2022 at 08:05:01AM -0600, Rob Herring wrote:
> > On Thu, 16 Jun 2022 01:54:03 +0200, Christian Marangi wrote:
> > > Rework the qcom,adm Documentation to yaml schema.
> > > This is not a pure conversion since originally the driver has changed
> > > implementation for the #dma-cells and was wrong from the start.
> > > Also the driver now handles the common DMA clients implementation with
> > > the first cell that denotes the channel number and nothing else since
> > > the client will have to provide the crci information via other means.
> > > 
> > > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > > ---
> > > v2:
> > > - Change Sob to Christian Marangi
> > > - Add Bjorn in the maintainers list
> > > 
> > >  .../devicetree/bindings/dma/qcom,adm.yaml     | 96 +++++++++++++++++++
> > >  .../devicetree/bindings/dma/qcom_adm.txt      | 61 ------------
> > >  2 files changed, 96 insertions(+), 61 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/dma/qcom,adm.yaml
> > >  delete mode 100644 Documentation/devicetree/bindings/dma/qcom_adm.txt
> > > 
> > 
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> > 
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> > 
> > Full log is available here: https://patchwork.ozlabs.org/patch/
> > 
> > 
> > dma-controller@...00000: reset-names:1: 'c0' was expected
> > 	arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> > 	arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> > 
> > dma-controller@...00000: reset-names:2: 'c1' was expected
> > 	arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> > 	arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> > 
> > dma-controller@...00000: reset-names:3: 'c2' was expected
> > 	arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> > 	arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> > 
> > dma-controller@...00000: reset-names: ['clk', 'pbus', 'c0', 'c1', 'c2'] is too long
> > 	arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> > 	arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> > 
> > dma-controller@...00000: resets: [[11, 13], [11, 12], [11, 11], [11, 10], [11, 9]] is too long
> > 	arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> > 	arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> >
> 
> I should have fixed this with the other patch. 

Ah, okay.

> Should the conversion fix
> this directly?

Given it was clearly wrong, that would be fine with a note in the commit 
message about the change. But no need to respin just for that.

Rob