linux-kernel - RE: [Non-DoD Source] [PATCH v3 15/15] md/raid5: Increase restriction on max segments per request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Jun 2022 21:32:21 +0000
From:   "Finlayson, James M CIV (USA)" <james.m.finlayson4.civ@...l.mil>
To:     'Logan Gunthorpe' <logang@...tatee.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
        Song Liu <song@...nel.org>
CC:     Christoph Hellwig <hch@...radead.org>,
        Guoqing Jiang <guoqing.jiang@...ux.dev>,
        Stephen Bates <sbates@...thlin.com>,
        "Martin Oliveira" <Martin.Oliveira@...eticom.com>,
        David Sloan <David.Sloan@...eticom.com>,
        "Finlayson, James M CIV (USA)" <james.m.finlayson4.civ@...l.mil>
Subject: RE: [Non-DoD Source] [PATCH v3 15/15] md/raid5: Increase
 restriction on max segments per request

Innocent question from position of ignorance....I see these last 15 check-ins all as performance improvements.   I tend to push hard on mdraid performance, but have RAID6 needs....are these some optimizations available for RAID6 and are they in process or did I just ask a silly question?

Regards,
Jim Finlayson
US Department of Defense

-----Original Message-----
From: Logan Gunthorpe <logang@...tatee.com> 
Sent: Thursday, June 16, 2022 3:20 PM
To: linux-kernel@...r.kernel.org; linux-raid@...r.kernel.org; Song Liu <song@...nel.org>
Cc: Christoph Hellwig <hch@...radead.org>; Guoqing Jiang <guoqing.jiang@...ux.dev>; Stephen Bates <sbates@...thlin.com>; Martin Oliveira <Martin.Oliveira@...eticom.com>; David Sloan <David.Sloan@...eticom.com>; Logan Gunthorpe <logang@...tatee.com>
Subject: [Non-DoD Source] [PATCH v3 15/15] md/raid5: Increase restriction on max segments per request

The block layer defaults the maximum segments to 128, which means requests tend to get split around the 512KB depending on how many pages can be merged. There's no such restriction in the raid5 code so increase the limit to USHRT_MAX so that larger requests can be sent as one.

Signed-off-by: Logan Gunthorpe <logang@...tatee.com>
---
 drivers/md/raid5.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index e48c16bfe657..5723a497108a 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -8005,6 +8005,9 @@ static int raid5_run(struct mddev *mddev)
 		 */
 		blk_queue_max_hw_sectors(mddev->queue,
 			RAID5_MAX_REQ_STRIPES << RAID5_STRIPE_SHIFT(conf));
+
+		/* No restrictions on the number of segments in the request */
+		blk_queue_max_segments(mddev->queue, USHRT_MAX);
 	}
 
 	if (log_init(conf, journal_dev, raid5_has_ppl(conf)))
--
2.30.2