linux-kernel - Re: [PATCH 0/2] media: cedrus: fix HEVC decoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3178102.44csPzL39Z@jernej-laptop>
Date:   Thu, 16 Jun 2022 23:46:52 +0200
From:   Jernej Škrabec <jernej.skrabec@...il.com>
To:     mripard@...nel.org, paul.kocialkowski@...tlin.com,
        Hans Verkuil <hverkuil-cisco@...all.nl>
Cc:     mchehab@...nel.org, wens@...e.org, samuel@...lland.org,
        benjamin.gaignard@...labora.com, nicolas.dufresne@...labora.com,
        gregkh@...uxfoundation.org, linux-media@...r.kernel.org,
        linux-staging@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] media: cedrus: fix HEVC decoding

Dne četrtek, 16. junij 2022 ob 09:14:05 CEST je Hans Verkuil napisal(a):
> On 6/15/22 22:44, Jernej Skrabec wrote:
> > After detailed comparison of register names to vendor library I noticed
> > that one register has completely different name. After some testing I
> > discovered that it was misnamed and used incorrectly. This patch series
> > fixes it. With that, 3 more reference bitstreams are now correctly
> > decoded. It is also possible that this fixes instability issue I had
> > after decoding such bitstreams. Running Fluster test suite very often
> > locked up my board, but after applying this fix, I never experienced it
> > again. It might still be completely coincidental, but I doubt this is
> > the case.
> > 
> > Note: Patch 2 clashes with HEVC uAPI destaging. In current form, it can
> > be easily backported. However, there are few users of Cedrus HEVC and
> > skipping this fix wouldn't be that bad.
> > 
> > Please let me know which way to go:
> > 1) wait for destaging, send rebased v2 and not care about backporting
> 
> Let's go with 1. There is not much point in backporting since destaging
> the HEVC API will also change it, so userspace will need to adapt. It's
> a staging driver anyway (although hopefully not for long).
> 
> If you post a v2 on top of the latest series from Benjamin, then that
> should almost certainly work fine when Benjamin posts what will hopefully
> be the final version of his series. When it is all OK, then I put both in
> the same PR.

I actually have several patches for Cedrus HEVC which I plan to send soon. 
They would apply on top of series from Benjamin and would implement all 
missing decoding features, except maybe 10-bit support. I'll include these two 
patches in that series.

Best regards,
Jernej

> 
> Regards,
> 
> 	Hans
> 
> > 2) merge before destaging, but v9 of HEVC uAPI destaging would need to
> > 
> >    be rebased.
> > 
> > 3) something else?
> > 
> > Best regards,
> > Jernej
> > 
> > Jernej Skrabec (2):
> >   media: cedrus: h265: Fix flag name
> >   media: cedrus: h265: Fix logic for not low delay flag
> >  
> >  .../staging/media/sunxi/cedrus/cedrus_h265.c  | 29 ++++++++++++++++++-
> >  .../staging/media/sunxi/cedrus/cedrus_regs.h  |  3 +-
> >  2 files changed, 29 insertions(+), 3 deletions(-)