linux-kernel - Re: [PATCH] selftests: make use of GUP_TEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30ac57f2-c95b-27f3-888e-d89c125770b0@linuxfoundation.org>
Date:   Thu, 16 Jun 2022 17:07:44 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Nico Pache <npache@...hat.com>, Joel Savitz <jsavitz@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Shuah Khan <shuah@...nel.org>, Linux MM <linux-mm@...ck.org>,
        linux-kselftest@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: make use of GUP_TEST_FILE macro

On 6/9/22 3:50 PM, Nico Pache wrote:
> LGTM! Good catch :)
> 
> Acked-by: Nico Pache <npache@...hat.com>
> 
> On Thu, Jun 9, 2022 at 4:37 PM Joel Savitz <jsavitz@...hat.com> wrote:
>>
>> Commit 17de1e559cf1 ("selftests: clarify common error when running
>> gup_test") had most of its hunks dropped due to a conflict with another
>> patch accepted into Linux around the same time that implemented the same
>> behavior as a subset of other changes.
>>
>> However, the remaining hunk defines the GUP_TEST_FILE macro without
>> making use of it. This patch makes use of the macro in the two relevant
>> places.
>>
>> Furthermore, the above mentioned commit's log message erroneously describes
>> the changes that were dropped from the patch.
>>
>> This patch corrects the record.
>>
>> Fixes: 17de1e559cf1 ("selftests: clarify common error when running gup_test")
>>
>> Signed-off-by: Joel Savitz <jsavitz@...hat.com>
>> ---

Applied to linux-kselftest fixes for next rc

thanks,
-- Shuah