linux-kernel - Re: [PATCH v2] Documentation: highmem: Use literal block for *kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YqqTtmkQzqzpoyzO@casper.infradead.org>
Date:   Thu, 16 Jun 2022 03:21:42 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     linux-doc@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ira Weiny <ira.weiny@...el.com>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Documentation: highmem: Use literal block for
 *kmap_local_folio() example

On Thu, Jun 16, 2022 at 08:38:38AM +0700, Bagas Sanjaya wrote:
> On 6/15/22 21:37, Matthew Wilcox wrote:
> > On Wed, Jun 15, 2022 at 05:15:10PM +0700, Bagas Sanjaya wrote:
> >> These warnings above are due to comments in code example of
> >> kmap_atomic() inside kernel-doc comment of *kmap_local_folio() are enclosed
> > 
> > You still seem to think this has something to do with kmap_local_folio().
> > It has nothing to do with kmap_local_folio().  Your next version of this
> > patch should not mention kmap_local_folio() anywhere.
> > 
> 
> But I think mentioning kmap_local_folio() is necessary in the patch
> subject, because we know the original warning is pointed to kernel-doc
> comment of that funcion.

No it doesn't.  It just gives a line number.  At least, all you quoted
was the line number.