[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bcd06ab1-6ead-985b-eff8-cbc526a8aa84@opensource.wdc.com>
Date: Thu, 16 Jun 2022 11:55:15 +0900
From: Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To: Edward Wu <edwardwu@...ltek.com>,
Steven Rostedt <rostedt@...dmis.org>,
Ingo Molnar <mingo@...hat.com>, Hannes Reinecke <hare@...e.de>,
Tejun Heo <tj@...nel.org>, linux-ide@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ata: libata: add qc->flags in ata_qc_complete_template
tracepoint
On 6/16/22 09:48, Edward Wu wrote:
> Add flags value to check the result of ata completion
>
> Fixes: 255c03d15a29 ("libata: Add tracepoints")
> Link: https://lkml.kernel.org/r/20220616001615.11636-1-edwardwu@realtek.com
What is this Link tag for ? I do not think it is needed.
And please add:
Cc: stable@...r.kernel.org
> Signed-off-by: Edward Wu <edwardwu@...ltek.com>
> ---
> v2:
> - Add Fixes tag
>
> include/trace/events/libata.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
> index d4e631aa976f..6025dd8ba4aa 100644
> --- a/include/trace/events/libata.h
> +++ b/include/trace/events/libata.h
> @@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
> __entry->hob_feature = qc->result_tf.hob_feature;
> __entry->nsect = qc->result_tf.nsect;
> __entry->hob_nsect = qc->result_tf.hob_nsect;
> + __entry->flags = qc->flags;
> ),
>
> TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \
--
Damien Le Moal
Western Digital Research
Powered by blists - more mailing lists