linux-kernel - Re: [net] net: dsa: felix: update base time of time-aware shaper when adjusting PTP time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220615195820.53bae850@kernel.org>
Date:   Wed, 15 Jun 2022 19:58:20 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Xiaoliang Yang <xiaoliang.yang_1@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, allan.nielsen@...rochip.com,
        joergen.andreasen@...rochip.com, horatiu.vultur@...rochip.com,
        UNGLinuxDriver@...rochip.com, alexandre.belloni@...tlin.com,
        fido_max@...ox.ru, alexandru.marginean@....com,
        claudiu.manoil@....com, vladimir.oltean@....com,
        leoyang.li@....com, yangbo.lu@....com
Subject: Re: [net] net: dsa: felix: update base time of time-aware shaper
 when adjusting PTP time

On Wed, 15 Jun 2022 11:36:10 +0800 Xiaoliang Yang wrote:
> When adjusting the PTP clock, the base time of the TAS configuration
> will become unreliable. We need reset the TAS configuration by using a
> new base time.
> 
> For example, if the driver gets a base time 0 of Qbv configuration from
> user, and current time is 20000. The driver will set the TAS base time
> to be 20000. After the PTP clock adjustment, the current time becomes
> 10000. If the TAS base time is still 20000, it will be a future time,
> and TAS entry list will stop running. Another example, if the current
> time becomes to be 10000000 after PTP clock adjust, a large time offset
> can cause the hardware to hang.
> 
> This patch introduces a tas_clock_adjust() function to reset the TAS
> module by using a new base time after the PTP clock adjustment. This can
> avoid issues above.
> 
> Due to PTP clock adjustment can occur at any time, it may conflict with
> the TAS configuration. We introduce a new TAS lock to serialize the
> access to the TAS registers.
> 
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@....com>

You missed some CCs (./scripts/get_maintainer.pl) and there needs to 
be a Fixes tag if you're targeting net.