linux-kernel - Re:Re: [PATCH] drivers: soc: sifive: Add missing of_node_put() in sifive_l2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Jun 2022 12:54:50 +0800 (CST)
From:   "Liang He" <windhl@....com>
To:     "kernel test robot" <lkp@...el.com>
Cc:     palmer@...belt.com, paul.walmsley@...ive.com,
        aou@...s.berkeley.edu, kbuild-all@...ts.01.org,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re:Re: [PATCH] drivers: soc: sifive: Add missing of_node_put() in
 sifive_l2_cache.c





At 2022-06-16 05:58:05, "kernel test robot" <lkp@...el.com> wrote:
>Hi Liang,
>
>Thank you for the patch! Yet something to improve:
>
>[auto build test ERROR on linus/master]
>[also build test ERROR on v5.19-rc2 next-20220615]
>[If your patch is applied to the wrong git tree, kindly drop us a note.
>And when submitting patch, we suggest to use '--base' as documented in
>https://git-scm.com/docs/git-format-patch]
>

When I use --base, there are too many prerequests-patch-id caused by my local commits. 
I don't know if it will cause other troubles. So I resent a new patch still without this '--base'.
Is it Ok?

Sorry, I forget to say in new patch that  is based on v5.19-rc2 mainline git repo.

>url:    https://github.com/intel-lab-lkp/linux/commits/Liang-He/drivers-soc-sifive-Add-missing-of_node_put-in-sifive_l2_cache-c/20220615-202528
>base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 018ab4fabddd94f1c96f3b59e180691b9e88d5d8
>config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20220616/202206160559.fVKJx0ST-lkp@intel.com/config)
>compiler: riscv64-linux-gcc (GCC) 11.3.0
>reproduce (this is a W=1 build):
>        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>        chmod +x ~/bin/make.cross
>        # https://github.com/intel-lab-lkp/linux/commit/49c4086768b5aff410a4a19ca740f8ae8e211844
>        git remote add linux-review https://github.com/intel-lab-lkp/linux
>        git fetch --no-tags linux-review Liang-He/drivers-soc-sifive-Add-missing-of_node_put-in-sifive_l2_cache-c/20220615-202528
>        git checkout 49c4086768b5aff410a4a19ca740f8ae8e211844
>        # save the config file
>        mkdir build_dir && cp config build_dir/.config
>        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/soc/
>
>If you fix the issue, kindly add following tag where applicable
>Reported-by: kernel test robot <lkp@...el.com>
>

Thanks for this report, now I make a new patch and add "Reported-by: kernel test robot <lkp@...el.com>"


>All errors (new ones prefixed by >>):
>
>   drivers/soc/sifive/sifive_l2_cache.c: In function 'sifive_l2_init':
>>> drivers/soc/sifive/sifive_l2_cache.c:224:17: error: expected ';' before 'goto'
>     224 |                 goto out_put;
>         |                 ^~~~
>
>

Thanks for all your effort to improve the patch.