| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Jun 2022 13:15:30 +0800
From: kernel test robot <lkp@...el.com>
To: Hongyu Xie <xy521521@...il.com>, mathias.nyman@...el.com,
gregkh@...uxfoundation.org
Cc: kbuild-all@...ts.01.org, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org, 125707942@...com, wangqi@...inos.cn,
xiongxin@...inos.cn, Hongyu Xie <xiehongyu1@...inos.cn>
Subject: Re: [PATCH v3 -next] usb: xhci: disable irq during initialization
Hi Hongyu,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20220615]
url: https://github.com/intel-lab-lkp/linux/commits/Hongyu-Xie/usb-xhci-disable-irq-during-initialization/20220616-110418
base: 6012273897fefb12566580efedee10bb06e5e6ed
config: xtensa-allyesconfig (https://download.01.org/0day-ci/archive/20220616/202206161315.DjaJzxlY-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/b8e08f7da837bf7aff0a032d4dbd6633c5a76f7d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Hongyu-Xie/usb-xhci-disable-irq-during-initialization/20220616-110418
git checkout b8e08f7da837bf7aff0a032d4dbd6633c5a76f7d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/usb/host/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/bitops.h:7,
from include/linux/log2.h:12,
from include/asm-generic/div64.h:55,
from ./arch/xtensa/include/generated/asm/div64.h:1,
from include/linux/math.h:6,
from include/linux/math64.h:6,
from include/linux/time64.h:5,
from include/linux/restart_block.h:10,
from include/linux/thread_info.h:14,
from arch/xtensa/include/asm/current.h:18,
from include/linux/mutex.h:14,
from include/linux/kernfs.h:11,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/pci.h:35,
from drivers/usb/host/xhci.c:11:
drivers/usb/host/xhci.c: In function 'xhci_run_finished':
drivers/usb/host/xhci.c:619:40: error: 'flags' undeclared (first use in this function)
619 | spin_lock_irqsave(&xhci->lock, flags);
| ^~~~~
include/linux/typecheck.h:11:16: note: in definition of macro 'typecheck'
11 | typeof(x) __dummy2; \
| ^
include/linux/spinlock.h:390:9: note: in expansion of macro 'raw_spin_lock_irqsave'
390 | raw_spin_lock_irqsave(spinlock_check(lock), flags); \
| ^~~~~~~~~~~~~~~~~~~~~
drivers/usb/host/xhci.c:619:9: note: in expansion of macro 'spin_lock_irqsave'
619 | spin_lock_irqsave(&xhci->lock, flags);
| ^~~~~~~~~~~~~~~~~
drivers/usb/host/xhci.c:619:40: note: each undeclared identifier is reported only once for each function it appears in
619 | spin_lock_irqsave(&xhci->lock, flags);
| ^~~~~
include/linux/typecheck.h:11:16: note: in definition of macro 'typecheck'
11 | typeof(x) __dummy2; \
| ^
include/linux/spinlock.h:390:9: note: in expansion of macro 'raw_spin_lock_irqsave'
390 | raw_spin_lock_irqsave(spinlock_check(lock), flags); \
| ^~~~~~~~~~~~~~~~~~~~~
drivers/usb/host/xhci.c:619:9: note: in expansion of macro 'spin_lock_irqsave'
619 | spin_lock_irqsave(&xhci->lock, flags);
| ^~~~~~~~~~~~~~~~~
>> include/linux/typecheck.h:12:25: warning: comparison of distinct pointer types lacks a cast
12 | (void)(&__dummy == &__dummy2); \
| ^~
include/linux/spinlock.h:247:17: note: in expansion of macro 'typecheck'
247 | typecheck(unsigned long, flags); \
| ^~~~~~~~~
include/linux/spinlock.h:390:9: note: in expansion of macro 'raw_spin_lock_irqsave'
390 | raw_spin_lock_irqsave(spinlock_check(lock), flags); \
| ^~~~~~~~~~~~~~~~~~~~~
drivers/usb/host/xhci.c:619:9: note: in expansion of macro 'spin_lock_irqsave'
619 | spin_lock_irqsave(&xhci->lock, flags);
| ^~~~~~~~~~~~~~~~~
vim +12 include/linux/typecheck.h
e0deaff470900a Andrew Morton 2008-07-25 4
e0deaff470900a Andrew Morton 2008-07-25 5 /*
e0deaff470900a Andrew Morton 2008-07-25 6 * Check at compile time that something is of a particular type.
e0deaff470900a Andrew Morton 2008-07-25 7 * Always evaluates to 1 so you may use it easily in comparisons.
e0deaff470900a Andrew Morton 2008-07-25 8 */
e0deaff470900a Andrew Morton 2008-07-25 9 #define typecheck(type,x) \
e0deaff470900a Andrew Morton 2008-07-25 10 ({ type __dummy; \
e0deaff470900a Andrew Morton 2008-07-25 11 typeof(x) __dummy2; \
e0deaff470900a Andrew Morton 2008-07-25 @12 (void)(&__dummy == &__dummy2); \
e0deaff470900a Andrew Morton 2008-07-25 13 1; \
e0deaff470900a Andrew Morton 2008-07-25 14 })
e0deaff470900a Andrew Morton 2008-07-25 15
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists