linux-kernel - Re: [PATCH v2] clk: tegra: (clk-tegra30) Add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220616060037.5AEB8C34114@smtp.kernel.org>
Date:   Wed, 15 Jun 2022 23:00:35 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Liang He <windhl@....com>, jonathanh@...dia.com,
        mturquette@...libre.com, pdeschrijver@...dia.com,
        pgaikwad@...dia.com, thierry.reding@...il.com
Cc:     linux-clk@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, windhl@....com
Subject: Re: [PATCH v2] clk: tegra: (clk-tegra30) Add missing of_node_put()

The subject should match historical subjects

 $ git log --oneline -3 -- drivers/clk/tegra/clk-tegra30.c

shows mostly "clk: tegra: ". Can you also combine this with the other
tegra patch? Don't think we need two patches for essentially the same
thing.

Quoting Liang He (2022-06-15 20:36:22)
> In tegra30_clock_init, of_find_matching_node() will return a node
> pointer with refcount incremented. We should use of_node_put() when
> the node pointer is not used anymore.
> 
> Signed-off-by: Liang He <windhl@....com>
> ---
>  changelog:
> 
>  v2: use real name for Sob

Thanks!

>  v1: fix missing bug