linux-kernel - Re: [PATCH V3 2/2] mm/mmap: Drop generic protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YqrJUgwW/ycqffvQ@infradead.org>
Date:   Wed, 15 Jun 2022 23:10:26 -0700
From:   "hch@...radead.org" <hch@...radead.org>
To:     Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     Anshuman Khandual <anshuman.khandual@....com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "hch@...radead.org" <hch@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH V3 2/2] mm/mmap: Drop generic protection_map[] array

On Thu, Jun 16, 2022 at 05:27:15AM +0000, Christophe Leroy wrote:
> 
> 
> Le 16/06/2022 à 06:09, Anshuman Khandual a écrit :
> > Move the protection_array[] array inside the arch for those platforms which
> 
> s/protection_array/protection_map
> 
> > do not enable ARCH_HAS_VM_GET_PAGE_PROT. Afterwards __SXXX/__PXX macros can
> > be dropped completely which are now redundant.
> 
> I see some protection_map[] are __ro_after_init, some not.
> 
> I'm sure several of them could be const as they are never modified.

Yes, most should be const as they are never modified.  A few have init
time modifications and can be __ro_after_init.  If we actually have
any that are modified later on that is a bug that we need to look into
with the respective arch maintainers.