linux-kernel - Re:Re: [PATCH v2] soc: sifive: (sifive_l2_cache) Add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3098748e.4883.1816b495c44.Coremail.windhl@126.com>
Date:   Thu, 16 Jun 2022 14:52:58 +0800 (CST)
From:   "Liang He" <windhl@....com>
To:     Conor.Dooley@...rochip.com
Cc:     palmer@...belt.com, paul.walmsley@...ive.com,
        aou@...s.berkeley.edu, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, lkp@...el.com
Subject: Re:Re: [PATCH v2] soc: sifive: (sifive_l2_cache) Add missing
 of_node_put()



At 2022-06-16 14:26:17, Conor.Dooley@...rochip.com wrote:
>On 16/06/2022 06:54, Liang He wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>> 
>> At 2022-06-16 12:49:15, "Liang He" <windhl@....com> wrote:
>>> In sifive_l2_init(), of_find_matching_node() will return a node pointer
>>> with refcount incremented. We should use of_node_put() in each fail path
>>> or when it is not used anymore.
>>>
>>> Reported-by: kernel test robot <lkp@...el.com>
>>>
>>> Signed-off-by: Liang He <windhl@....com>
>>> ---
>> 
>> 
>> Sorry, please ignore this version as it still has a bug.  I will have a strict check and compile the code before my next commit.
>
>While you're at it - drop the Reported-by too.
>You only need to include that if LKP found a problem with
>a patch that's been applied already. If it's on something
>in progress, just fix what it pointed out & resend.
>
>Thanks,
>Conor.
>


Thanks for all your help, Conor.

I will make a proper patch considering all things you suggested.