linux-kernel - Re: [PATCH v4 -next] usb: xhci: disable irq during initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab92690c-c3ee-ab92-5763-376db208aebb@kylinos.cn>
Date:   Thu, 16 Jun 2022 16:24:08 +0800
From:   谢泓宇 <xiehongyu1@...inos.cn>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Hongyu Xie <xy521521@...il.com>
Cc:     mathias.nyman@...el.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, 125707942@...com, wangqi@...inos.cn,
        xiongxin@...inos.cn, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v4 -next] usb: xhci: disable irq during initialization

Hi greg,

On 2022/6/16 16:12, Greg KH wrote:
> On Thu, Jun 16, 2022 at 04:09:33PM +0800, Hongyu Xie wrote:
>> irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared
>> in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it.
>> It's possible that you will receive thousands of interrupt requests
>> after initialization for 2.0 roothub. And you will get a lot of
>> warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be
>> disabled?". This amount of interrupt requests will cause the entire
>> system to freeze.
>> This problem was first found on a device with ASM2142 host controller
>> on it.
>>
>> Signed-off-by: Hongyu Xie <xiehongyu1@...inos.cn>
>> Reported-by: kernel test robot <lkp@...el.com>
> 
> the test robot did not find this original problem, it only found
> problems with your original submission, which is different.
> 
"Reported-by" shouldn't had been put here.
Quote from the last email test robot sent to me，
"If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>"
Where should I put this? Or just ignore it?