linux-kernel - Re:Re: [PATCH v2] drivers: clk: (clk-nomadik) Add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22796950.5fb1.1816b9d67a7.Coremail.windhl@126.com>
Date:   Thu, 16 Jun 2022 16:24:46 +0800 (CST)
From:   "Liang He" <windhl@....com>
To:     "Stephen Boyd" <sboyd@...nel.org>, Conor.Dooley@...rochip.com
Cc:     linus.walleij@...aro.org, mturquette@...libre.com,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re:Re: [PATCH v2] drivers: clk: (clk-nomadik) Add missing
 of_node_put()



At 2022-06-16 14:02:23, "Stephen Boyd" <sboyd@...nel.org> wrote:
>Same subject line comment applies here. Look at previous patches to the
>file.

Sorry, what do you mean same subject line comment?

I add a [PATCH v2] tag when I use 'git format-patch -v 2'.

You mean the two commit has same subject content?

Sorry, I am a beginner to submit patch commit.

>
>Quoting Liang He (2022-06-15 20:24:48)
>> diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c
>> index bad2677e11ae..48d5772b36a5 100644
>> --- a/drivers/clk/clk-nomadik.c
>> +++ b/drivers/clk/clk-nomadik.c
>> @@ -99,7 +99,7 @@ static void __init nomadik_src_init(void)
>>         if (!src_base) {
>>                 pr_err("%s: must have src parent node with REGS (%pOFn)\n",
>>                        __func__, np);
>> -               return;
>> +               goto out_put;
>>         }
>>  
>>         /* Set all timers to use the 2.4 MHz TIMCLK */
>> @@ -132,6 +132,9 @@ static void __init nomadik_src_init(void)
>>         }
>>         writel(val, src_base + SRC_XTALCR);
>>         register_reboot_notifier(&nomadik_clk_reboot_notifier);
>> +       
>> +output:
>> +    of_node_put(np);   
>
>tabbed incorrectly?

Sorry for this incorrct tab setting.