linux-kernel - Re: [PATCH] init: Initialize noop_backing_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220616090052.6xhfljxcis7ymqlb@quack3.lan>
Date:   Thu, 16 Jun 2022 11:00:52 +0200
From:   Jan Kara <jack@...e.cz>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Jan Kara <jack@...e.cz>, LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-mm@...ck.org, Suzuki K Poulose <suzuki.poulose@....com>,
        Guenter Roeck <linux@...ck-us.net>,
        Alexandru Elisei <alexandru.elisei@....com>
Subject: Re: [PATCH] init: Initialize noop_backing_dev_info early

On Wed 15-06-22 23:08:22, Christoph Hellwig wrote:
> On Wed, Jun 15, 2022 at 11:48:15PM +0200, Jan Kara wrote:
> > +extern int bdi_init(struct backing_dev_info *bdi);
> 
> No need for the extern.

Yes, fixed up.

> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>

Thanks for review!

> And this remind me that I really want to kill noop_backing_dev_info
> and just use a NULL bdi for this case eventually..

Yes, I'm just not sure whether the checks for bdi / wb being NULL in lots
of places will not be too annoying... But maybe you'll be able to come up
with some wrappers that will make things bearable.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR