linux-kernel - Re: [PATCH] selftests: netfilter: correct PKTGEN_SCRIPT_PATHS in nft_concat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yqr9pQ9QsVaGjNW/@salvia>
Date:   Thu, 16 Jun 2022 11:53:41 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Jie2x Zhou <jie2x.zhou@...el.com>
Cc:     shuah@...nel.org, sbrivio@...hat.com, liuhangbin@...il.com,
        fw@...len.de, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, Philip Li <philip.li@...el.com>,
        kernel test robot <lkp@...el.com>,
        netfilter-devel@...r.kernel.org
Subject: Re: [PATCH] selftests: netfilter: correct PKTGEN_SCRIPT_PATHS in
 nft_concat_range.sh

Cc'ing netfilter-devel and Stefano Brivio.

On Thu, Jun 16, 2022 at 03:40:46PM +0800, Jie2x Zhou wrote:
> Before change:
> make -C netfilter
>  TEST: performance
>    net,port                                                      [SKIP]
>    perf not supported
>    port,net                                                      [SKIP]
>    perf not supported
>    net6,port                                                     [SKIP]
>    perf not supported
>    port,proto                                                    [SKIP]
>    perf not supported
>    net6,port,mac                                                 [SKIP]
>    perf not supported
>    net6,port,mac,proto                                           [SKIP]
>    perf not supported
>    net,mac                                                       [SKIP]
>    perf not supported
> 
> After change:
>    net,mac                                                       [ OK ]
>      baseline (drop from netdev hook):               2061098pps
>      baseline hash (non-ranged entries):             1606741pps
>      baseline rbtree (match on first field only):    1191607pps
>      set with  1000 full, ranged entries:            1639119pps
> ok 8 selftests: netfilter: nft_concat_range.sh
> 
> Fixes: 611973c1e06f ("selftests: netfilter: Introduce tests for sets with range concatenation")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Jie2x Zhou <jie2x.zhou@...el.com>
> ---
>  tools/testing/selftests/netfilter/nft_concat_range.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/netfilter/nft_concat_range.sh b/tools/testing/selftests/netfilter/nft_concat_range.sh
> index b35010cc7f6a..a6991877e50c 100755
> --- a/tools/testing/selftests/netfilter/nft_concat_range.sh
> +++ b/tools/testing/selftests/netfilter/nft_concat_range.sh
> @@ -31,7 +31,7 @@ BUGS="flush_remove_add reload"
>  
>  # List of possible paths to pktgen script from kernel tree for performance tests
>  PKTGEN_SCRIPT_PATHS="
> -	../../../samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh
> +	../../../../samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh
>  	pktgen/pktgen_bench_xmit_mode_netif_receive.sh"
>  
>  # Definition of set types:
> -- 
> 2.34.1
>