[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <92c922ed-cc04-6e55-9c12-81a43332b318@samsung.com>
Date: Thu, 16 Jun 2022 12:28:44 +0200
From: Pankaj Raghav <p.raghav@...sung.com>
To: Randy Dunlap <rdunlap@...radead.org>, <hch@....de>,
<snitzer@...hat.com>, <damien.lemoal@...nsource.wdc.com>,
<axboe@...nel.dk>
CC: <bvanassche@....org>, <linux-kernel@...r.kernel.org>,
<jiangbo.365@...edance.com>, <hare@...e.de>, <pankydev8@...il.com>,
<dm-devel@...hat.com>, <jonathan.derrick@...ux.dev>,
<gost.dev@...sung.com>, <dsterba@...e.com>, <jaegeuk@...nel.org>,
<linux-nvme@...ts.infradead.org>, <Johannes.Thumshirn@....com>,
<linux-block@...r.kernel.org>,
Damien Le Moal <damien.lemoal@....com>
Subject: Re: [PATCH v7 13/13] dm: add non power of 2 zoned target
On 2022-06-15 21:54, Randy Dunlap wrote:
> Hi--
>
> On 6/15/22 03:19, Pankaj Raghav wrote:
>
>> ---
>> drivers/md/Kconfig | 9 +
>> drivers/md/Makefile | 2 +
>> drivers/md/dm-zone.c | 9 +
>> drivers/md/dm-zoned-npo2-target.c | 268 ++++++++++++++++++++++++++++++
>> 4 files changed, 288 insertions(+)
>> create mode 100644 drivers/md/dm-zoned-npo2-target.c
>>
>> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
>> index 998a5cfdb..773314536 100644
>> --- a/drivers/md/Kconfig
>> +++ b/drivers/md/Kconfig
>> @@ -518,6 +518,15 @@ config DM_FLAKEY
>> help
>> A target that intermittently fails I/O for debugging purposes.
>>
>> +config DM_ZONED_NPO2
>> + tristate "Zoned non power of 2 target"
>
> "Zoned non-power-of-2 target"
>
>> + depends on BLK_DEV_DM
>> + depends on BLK_DEV_ZONED
>> + help
>> + A target that converts a zoned device with non power of 2 zone size to
>
> non-power-of-2 zone size to
>
>> + be power of 2. This is done by introducing gaps in between the zone
>> + capacity and the power of 2 zone size.
>
> All help text should be indented with one tab and 2 spaces
> according to Documentation/process/coding-style.rst.
>
>> +
>> config DM_VERITY
>> tristate "Verity target support"
>> depends on BLK_DEV_DM
>
> [snip]
>
>> +
>> +MODULE_DESCRIPTION(DM_NAME " non power 2 zoned target");
>
> non-power-of-2
>
>> +MODULE_AUTHOR("Pankaj Raghav <p.raghav@...sung.com>");
>> +MODULE_LICENSE("GPL");
>> +
>
Thanks Randy. Fixed.
Powered by blists - more mailing lists