lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Jun 2022 19:39:22 +0800 From: Xuezhi Zhang <zhangxuezhi1@...lpad.com> To: satishkh@...co.com, sebaddel@...co.com, kartilak@...co.com, jejb@...ux.ibm.com, martin.petersen@...cle.com Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, Xuezhi Zhang <zhangxuezhi1@...lpad.com> Subject: [PATCH] scsi: fnic: convert sysfs snprintf to sysfs_emit Fix the following coccicheck warnings: drivers/scsi/fnic/fnic_attrs.c:35:8-16: WARNING: use scnprintf or sprintf drivers/scsi/fnic/fnic_attrs.c:43:8-16: WARNING: use scnprintf or sprintf drivers/scsi/fnic/fnic_attrs.c:29:8-16: WARNING: use scnprintf or sprintf Signed-off-by: Xuezhi Zhang <zhangxuezhi1@...lpad.com> --- drivers/scsi/fnic/fnic_attrs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/fnic/fnic_attrs.c b/drivers/scsi/fnic/fnic_attrs.c index bbe2ca4971b2..d02555bf3df1 100644 --- a/drivers/scsi/fnic/fnic_attrs.c +++ b/drivers/scsi/fnic/fnic_attrs.c @@ -26,13 +26,13 @@ static ssize_t fnic_show_state(struct device *dev, struct fc_lport *lp = shost_priv(class_to_shost(dev)); struct fnic *fnic = lport_priv(lp); - return snprintf(buf, PAGE_SIZE, "%s\n", fnic_state_str[fnic->state]); + return sysfs_emit(buf, "%s\n", fnic_state_str[fnic->state]); } static ssize_t fnic_show_drv_version(struct device *dev, struct device_attribute *attr, char *buf) { - return snprintf(buf, PAGE_SIZE, "%s\n", DRV_VERSION); + return sysfs_emit(buf, "%s\n", DRV_VERSION); } static ssize_t fnic_show_link_state(struct device *dev, @@ -40,7 +40,7 @@ static ssize_t fnic_show_link_state(struct device *dev, { struct fc_lport *lp = shost_priv(class_to_shost(dev)); - return snprintf(buf, PAGE_SIZE, "%s\n", (lp->link_up) + return sysfs_emit(buf, "%s\n", (lp->link_up) ? "Link Up" : "Link Down"); } -- 2.34.1
Powered by blists - more mailing lists