linux-kernel - Re: [PATCH 1/4] dt-bindings: gpio: Add AXP221/AXP223/AXP809 compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Jun 2022 06:57:01 -0700
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Samuel Holland <samuel@...lland.org>, Chen-Yu Tsai <wens@...e.org>,
        Lee Jones <lee.jones@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio@...r.kernel.org
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: gpio: Add AXP221/AXP223/AXP809
 compatibles

On 15/06/2022 23:09, Samuel Holland wrote:
> These PMICs each have 2 GPIOs with the same register layout as AXP813,
> but without an ADC function.
> 
> Signed-off-by: Samuel Holland <samuel@...lland.org>
> ---
> 
>  .../devicetree/bindings/gpio/x-powers,axp209-gpio.yaml     | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml b/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml
> index 0f628b088cec..6faa3ef28960 100644
> --- a/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/x-powers,axp209-gpio.yaml
> @@ -19,7 +19,14 @@ properties:
>      oneOf:
>        - enum:
>            - x-powers,axp209-gpio
> +          - x-powers,axp221-gpio
>            - x-powers,axp813-gpio
> +      - items:
> +          - const: x-powers,axp223-gpio
> +          - const: x-powers,axp221-gpio
> +      - items:
> +          - const: x-powers,axp809-gpio

This is just an enum with 223 and 809. No need for two separate entries
here.

> +          - const: x-powers,axp221-gpio
>        - items:
>            - const: x-powers,axp803-gpio
>            - const: x-powers,axp813-gpio


Best regards,
Krzysztof