[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fb8e7e35-7f26-15bc-9fbb-2949fc80a18b@infradead.org>
Date: Thu, 16 Jun 2022 08:02:22 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Quan Nguyen <quan@...amperecomputing.com>,
Corey Minyard <minyard@....org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Brendan Higgins <brendanhiggins@...gle.com>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Joel Stanley <joel@....id.au>,
Andrew Jeffery <andrew@...id.au>,
Wolfram Sang <wsa@...nel.org>,
openipmi-developer@...ts.sourceforge.net,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-i2c@...r.kernel.org, openbmc@...ts.ozlabs.org,
linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org
Cc: Open Source Submission <patches@...erecomputing.com>,
Phong Vo <phong@...amperecomputing.com>,
"Thang Q . Nguyen" <thang@...amperecomputing.com>
Subject: Re: [PATCH v8 1/3] ipmi: ssif_bmc: Add SSIF BMC driver
On 6/16/22 00:25, Quan Nguyen wrote:
> On 15/06/2022 23:06, Randy Dunlap wrote:
>>
>>
>> On 6/15/22 02:02, Quan Nguyen wrote:
>>> diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
>>> index b061e6b513ed..18a89093d64e 100644
>>> --- a/drivers/char/ipmi/Kconfig
>>> +++ b/drivers/char/ipmi/Kconfig
>>> @@ -169,6 +169,17 @@ config ASPEED_BT_IPMI_BMC
>>> found on Aspeed SOCs (AST2400 and AST2500). The driver
>>> implements the BMC side of the BT interface.
>>> +config SSIF_IPMI_BMC
>>> + tristate "SSIF IPMI BMC driver"
>>> + select I2C
>>
>> No. That should be:
>> depends on I2C
>>
>> We don't select an entire subsystem just to satisfy one driver.
>>
>>> + select I2C_SLAVE
>>> + help
>>> + This enables the IPMI SMBus system interface (SSIF) at the
>>> + management (BMC) side.
>>> +
>>> + The driver implements the BMC side of the SMBus system
>>> + interface (SSIF).
>>> +
>>
>> Thanks.
>
> Thanks Randy,
> it should be change to "depends on I2C && I2C_SLAVE"
Either way is OK for I2C_SLAVE AFAIK.
thanks.
--
~Randy
Powered by blists - more mailing lists