[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220616153017.GA3503416-robh@kernel.org>
Date: Thu, 16 Jun 2022 09:30:17 -0600
From: Rob Herring <robh@...nel.org>
To: Sebastian Ene <sebastianene@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Arnd Bergmann <arnd@...db.de>,
Dragan Cvetic <dragan.cvetic@...inx.com>,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
maz@...nel.org, will@...nel.org, vdonnefort@...gle.com,
Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH v6 1/2] dt-bindings: vcpu_stall_detector: Add
qemu,vcpu-stall-detector compatible
On Thu, Jun 16, 2022 at 09:27:38AM +0000, Sebastian Ene wrote:
> The VCPU stall detection mechanism allows to configure the expiration
> duration and the internal counter clock frequency measured in Hz.
> Add these properties in the schema.
>
> While this is a memory mapped virtual device, it is expected to be loaded
> when the DT contains the compatible: "qemu,vcpu-stall-detector" node.
> In a protected VM we trust the generated DT nodes and we don't rely on
> the host to present the hardware peripherals.
>
> Signed-off-by: Sebastian Ene <sebastianene@...gle.com>
> ---
> .../bindings/misc/vcpu_stall_detector.yaml | 49 +++++++++++++++++++
qemu,vcpu-stall-detector.yaml
> 1 file changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/misc/vcpu_stall_detector.yaml
>
> diff --git a/Documentation/devicetree/bindings/misc/vcpu_stall_detector.yaml b/Documentation/devicetree/bindings/misc/vcpu_stall_detector.yaml
> new file mode 100644
> index 000000000000..55323676194b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/vcpu_stall_detector.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/misc/vcpu_stall_detector.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: VCPU stall detector
> +
> +description: |
Don't need '|' if no formatting.
> + This binding describes a CPU stall detector mechanism for virtual cpus
s/cpus/CPUs/
> + which is accessed through MMIO.
> +
> +maintainers:
> + - Sebastian Ene <sebastianene@...gle.com>
> +
> +properties:
> + compatible:
> + enum:
> + - qemu,vcpu-stall-detector
> +
> + clock-frequency:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + The internal clock of the stall detector peripheral measure in Hz used
> + to decrement its internal counter register on each tick.
> + Defaults to 10 if unset.
default: 10
> +
> + timeout-sec:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + The stall detector expiration timeout measured in seconds.
> + Defaults to 8 if unset. Please note that it also takes into account the
> + time spent while the VCPU is not running.
default: 8
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + vmwdt@...0000 {
> + compatible = "qemu,vcpu-stall-detector";
> + clock-frequency = <10>;
> + timeout-sec = <8>;
> + reg = <0x0 0x9030000 0x0 0x10000>;
> + };
> +
> +...
> --
> 2.36.1.476.g0c4daa206d-goog
>
>
Powered by blists - more mailing lists