linux-kernel - Re: [PATCH v2] hwmon: (gsc-hwmon) Add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220617211719.GA632482@roeck-us.net>
Date:   Fri, 17 Jun 2022 14:17:19 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Liang He <windhl@....com>
Cc:     tharvey@...eworks.com, rjones@...eworks.com, jdelvare@...e.com,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hwmon: (gsc-hwmon) Add missing of_node_put()

On Thu, Jun 16, 2022 at 07:40:24PM +0800, Liang He wrote:
> In gsc_hwmon_get_devtree_pdata(), of_find_compatible_node() will return
> a node pointer with refcount incremented. We should use of_node_put() in
> fail path or when it is not used anymore.
> 
> Signed-off-by: Liang He <windhl@....com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/gsc-hwmon.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/hwmon/gsc-hwmon.c b/drivers/hwmon/gsc-hwmon.c
> index 1fe37418ff46..d64be48f1ef6 100644
> --- a/drivers/hwmon/gsc-hwmon.c
> +++ b/drivers/hwmon/gsc-hwmon.c
> @@ -269,10 +269,13 @@ gsc_hwmon_get_devtree_pdata(struct device *dev)
>  	/* fan controller base address */
>  	fan = of_find_compatible_node(dev->parent->of_node, NULL, "gw,gsc-fan");
>  	if (fan && of_property_read_u32(fan, "reg", &pdata->fan_base)) {
> +		of_node_put(fan);
>  		dev_err(dev, "fan node without base\n");
>  		return ERR_PTR(-EINVAL);
>  	}
>  
> +	of_node_put(fan);
> +
>  	/* allocate structures for channels and count instances of each type */
>  	device_for_each_child_node(dev, child) {
>  		if (fwnode_property_read_string(child, "label", &ch->name)) {