linux-kernel - Re: [PATCH v2 1/2] dt-bindings: mfd: mt6397: Add compatibles for MT6331 RTC and keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <074b6829-c5c1-d3fa-d4b9-8b0ba001eabe@gmail.com>
Date:   Fri, 17 Jun 2022 11:17:11 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, lee.jones@...aro.org
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        johnson.wang@...iatek.com, hsin-hsiung.wang@...iatek.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: mt6397: Add compatibles for
 MT6331 RTC and keys



On 16/06/2022 11:15, AngeloGioacchino Del Regno wrote:
> The MT6331 PMIC provides many sub modules: regulators, audio
> codec, LED controller, keys, RTC and some GPIOs.
> It is always paired with a MT6332 Companion PMIC, which provides
> thermistors, WLEDs (display LED backlight), secondary AP cluster
> regulators, modem clocks, battery charger and fuel gauge.
> 
> Add the necessary compatibles to start implementing the basics.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> ---
>   Documentation/devicetree/bindings/mfd/mt6397.txt | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt
> index 293db2a71ef2..f637bee2f3eb 100644
> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt
> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt
> @@ -29,6 +29,7 @@ Optional subnodes:
>   - rtc
>   	Required properties: Should be one of follows
>   		- compatible: "mediatek,mt6323-rtc"
> +		- compatible: "mediatek,mt6331-rtc"
>   		- compatible: "mediatek,mt6358-rtc"
>   		- compatible: "mediatek,mt6397-rtc"
>   	For details, see ../rtc/rtc-mt6397.txt
> @@ -52,8 +53,10 @@ Optional subnodes:
>   	see ../leds/leds-mt6323.txt
>   
>   - keys
> -	Required properties:
> -		- compatible: "mediatek,mt6397-keys" or "mediatek,mt6323-keys"
> +	Required properties: Should be one of the following
> +		- compatible: "mediatek,mt6323-keys"
> +		- compatible: "mediatek,mt6331-keys"
> +		- compatible: "mediatek,mt6397-keys"
>   	see ../input/mtk-pmic-keys.txt
>   
>   - power-controller