linux-kernel - Re: [PATCH v2] ACPI/processor: Remove unused function acpi_processor_get_limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v8szoccp.fsf@stealth>
Date:   Fri, 17 Jun 2022 10:42:14 +0100
From:   Punit Agrawal <punit.agrawal@...edance.com>
To:     Riwen Lu <luriwen@...mail.com>
Cc:     rafael@...nel.org, lenb@...nel.org, rui.zhang@...el.com,
        robert.moore@...el.com, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, devel@...ica.org,
        punit.agrawal@...edance.com, Riwen Lu <luriwen@...inos.cn>
Subject: Re: [PATCH v2] ACPI/processor: Remove unused function
 acpi_processor_get_limit_info()

Riwen Lu <luriwen@...mail.com> writes:

> From: Riwen Lu <luriwen@...inos.cn>
>
> Commit 22e7551eb6fd ("ACPI / processor: Remove acpi_processor_get_limit_info()"),
> left behind this, remove it.
>
> Signed-off-by: Riwen Lu <luriwen@...inos.cn>
>
> ---
> v1 -> v2:
>  - Make this patch base on ("ACPI: Split out processor thermal register
>    from ACPI PSS").

For such changes, it is better to send all the related patches as a
series so it's easy to see the dependencies . In a series the easy /
obvious fixes should be earlier so it's easier for them to be merged
while the more significant changes are still being discussed.

Hopefully in this case Rafael too agrees with the dependency patch -
otherwise, it's just extra churn on the lists.

But don't resend just yet - give some time for others to add their
feedback.

> ---
>  include/acpi/processor.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> index ba1e3ed98d3d..9fa49686957a 100644
> --- a/include/acpi/processor.h
> +++ b/include/acpi/processor.h
> @@ -441,7 +441,6 @@ static inline int acpi_processor_hotplug(struct acpi_processor *pr)
>  #endif /* CONFIG_ACPI_PROCESSOR_IDLE */
>  
>  /* in processor_thermal.c */
> -int acpi_processor_get_limit_info(struct acpi_processor *pr);
>  int acpi_processor_thermal_init(struct acpi_processor *pr,
>  				struct acpi_device *device);
>  void acpi_processor_thermal_exit(struct acpi_processor *pr,

Fwiw,

Reviewed-by: Punit Agrawal <punit.agrawal@...edance.com>