linux-kernel - Re: [PATCH v3 16/40] arm64: dts: mediatek: mt7622-bananapi-bpi-r64: align led node names with dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Jun 2022 12:43:46 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        arm@...nel.org, soc@...nel.org, Arnd Bergmann <arnd@...db.de>,
        Olof Johansson <olof@...om.net>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 16/40] arm64: dts: mediatek: mt7622-bananapi-bpi-r64:
 align led node names with dtschema



On 16/06/2022 02:53, Krzysztof Kozlowski wrote:
> The node names should be generic and DT schema expects certain pattern
> with 'led'.  Use generic color properties instead of the node name.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Applied, thanks!

> ---
>   arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> index c2311733d2de..7d1ecf72a6c3 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> @@ -8,6 +8,7 @@
>   /dts-v1/;
>   #include <dt-bindings/input/input.h>
>   #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
>   
>   #include "mt7622.dtsi"
>   #include "mt6380.dtsi"
> @@ -56,14 +57,16 @@ wps-key {
>   	leds {
>   		compatible = "gpio-leds";
>   
> -		green {
> +		led-0 {
>   			label = "bpi-r64:pio:green";
> +			color = <LED_COLOR_ID_GREEN>;
>   			gpios = <&pio 89 GPIO_ACTIVE_HIGH>;
>   			default-state = "off";
>   		};
>   
> -		red {
> +		led-1 {
>   			label = "bpi-r64:pio:red";
> +			color = <LED_COLOR_ID_RED>;
>   			gpios = <&pio 88 GPIO_ACTIVE_HIGH>;
>   			default-state = "off";
>   		};