linux-kernel - Re: [PATCH v4] scsi: support packing multi-segment in UNMAP command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1wndgnj4i.fsf@ca-mkp.ca.oracle.com>
Date:   Thu, 16 Jun 2022 22:01:59 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Chao Yu <chao@...nel.org>
Cc:     jejb@...ux.ibm.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        hch@...radead.org, bvanassche@....org
Subject: Re: [PATCH v4] scsi: support packing multi-segment in UNMAP command


Chao,

> As SCSI SBC4 specification section 5.30.2 describes that it can
> support unmapping one or more LBA range in single UNMAP command.
>
> However, previously we only pack one LBA range in UNMAP command by
> default no matter device gives the block limits that says it can
> support unmapping multiple LBA ranges with a single UNMAP command.
>
> This patch sets max_discard_segments config according to block limits
> of device, and supports unmapping multiple LBA ranges with a single
> UNMAP command.

This looks OK to me. Will test with a variety of targets.

-- 
Martin K. Petersen	Oracle Linux Engineering