linux-kernel - Re: [PATCH v4] soc: nuvoton: Add SoC info driver for WPCM450

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Jun 2022 13:39:56 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>
Cc:     Arnd Bergmann <arnd@...db.de>,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        Joel Stanley <joel@....id.au>,
        Paul Menzel <pmenzel@...gen.mpg.de>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Lubomir Rintel <lkundrak@...sk>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Hector Martin <marcan@...can.st>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Sven Peter <sven@...npeter.dev>,
        Heiko Stuebner <heiko@...ech.de>,
        Brian Norris <briannorris@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] soc: nuvoton: Add SoC info driver for WPCM450

On Fri, Jun 17, 2022 at 11:28 AM Jonathan Neuschäfer
<j.neuschaefer@....net> wrote:
> > Just add the trivial cleanup function and MODULE_LICENSE() etc tags.
>
> The right thing to do seems to be to unregister the SoC device in the
> cleanup function. Is that what you mean?

Yes, plus kfree() the soc_device_attribute, or make it statically allocated.

     Arnd