linux-kernel - [PATCH] firmware: Fix refcount leak bug in trusted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220617133553.4049515-1-windhl@126.com>
Date:   Fri, 17 Jun 2022 21:35:53 +0800
From:   Liang He <windhl@....com>
To:     linux-kernel@...r.kernel.org
Cc:     Liang He <windhl@....com>
Subject: [PATCH] firmware: Fix refcount leak bug in trusted_foundation

In of_register_trusted_foundations(), of_find_compatible_node() will
return a node pointer with refcount incremented. We should use
of_node_put() when it is not used anymore.

Signed-off-by: Liang He <windhl@....com>
---
 drivers/firmware/trusted_foundations.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/trusted_foundations.c b/drivers/firmware/trusted_foundations.c
index 1389fa9418a7..74ef947f5547 100644
--- a/drivers/firmware/trusted_foundations.c
+++ b/drivers/firmware/trusted_foundations.c
@@ -173,6 +173,7 @@ void of_register_trusted_foundations(void)
 		panic("Trusted Foundation: missing version-major property\n");
 	err = of_property_read_u32(node, "tlm,version-minor",
 				   &pdata.version_minor);
+	of_node_put(node);
 	if (err != 0)
 		panic("Trusted Foundation: missing version-minor property\n");
 	register_trusted_foundations(&pdata);
-- 
2.25.1