linux-kernel - Re: [PATCH v8] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220617153745.4a3a7a03.max@enpas.org>
Date:   Fri, 17 Jun 2022 15:37:45 +0200
From:   Max Staudt <max@...as.org>
To:     Vincent Mailhol <vincent.mailhol@...il.com>
Cc:     Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        linux-can@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Oliver Neukum <oneukum@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8] can, tty: can327 CAN/ldisc driver for ELM327 based
 OBD-II adapters

On Wed, 15 Jun 2022 19:00:10 +0900
Vincent Mailhol <vincent.mailhol@...il.com> wrote:

> Hi Max,
> 
> Because you will have to send a v9 for the split as requested by Marc,
> let me through a last couple of nitpicks.

Perfect, thanks for your help!


> Some of the function or struct names are still prefixed with elm327,
> some other with can327. Could you harmonize everything and use the
> same prefix throughout the file?

This was from back in the elmcan days, where I named the device
specific things according to the device, and the Linux glue according
to the driver. I agree, elm327/can327 is too similar and confusing now.

Done, thanks!


> > +/* Dummy needed to use bitrate_const */
> > +static int can327_do_set_bittiming(struct net_device *netdev)
> > +{
> > +       return 0;
> > +}  
> 
> Seems you forgot to remove that guy :)
> c.f.
> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/commit/?id=7e193a42c37cf40eba8ac5af2d5e8eeb8b9506f9

Oops m(
I've removed it now, thanks.


Max