linux-kernel - [PATCH] arm: mach-versatile: Fix refcount leak bug in versatile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220617134552.4050008-1-windhl@126.com>
Date:   Fri, 17 Jun 2022 21:45:52 +0800
From:   Liang He <windhl@....com>
To:     linus.walleij@...aro.org, linux@...linux.org.uk
Cc:     windhl@....com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] arm: mach-versatile: Fix refcount leak bug in versatile

In versatile_dt_init(), of_find_compatible_node() will return a node
pointer with refcount incremented. We should use of_node_put() when
it is not used anymore.

Signed-off-by: Liang He <windhl@....com>
---
 arch/arm/mach-versatile/versatile.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-versatile/versatile.c b/arch/arm/mach-versatile/versatile.c
index 02ba68abe533..97da874b5d4b 100644
--- a/arch/arm/mach-versatile/versatile.c
+++ b/arch/arm/mach-versatile/versatile.c
@@ -164,6 +164,7 @@ static void __init versatile_dt_init(void)
 	np = of_find_compatible_node(NULL, NULL, "arm,core-module-versatile");
 	if (np)
 		versatile_sys_base = of_iomap(np, 0);
+	of_node_put(np);
 	WARN_ON(!versatile_sys_base);
 
 	versatile_dt_pci_init();
-- 
2.25.1