linux-kernel - Re: [PATCH V2 net-next 4/4] net: marvell: prestera: implement software MDB entries allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202206172146.gg9GL71Z-lkp@intel.com>
Date:   Fri, 17 Jun 2022 22:01:27 +0800
From:   kernel test robot <lkp@...el.com>
To:     Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
        netdev@...r.kernel.org, Taras Chornyi <tchornyi@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org,
        Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
        Yevhen Orlov <yevhen.orlov@...ision.eu>
Subject: Re: [PATCH V2 net-next 4/4] net: marvell: prestera: implement
 software MDB entries allocation

Hi Oleksandr,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Oleksandr-Mazur/net-marvell-prestera-add-MDB-offloading-support/20220617-181737
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 982c3e2948d6a30d34f186e3b7d592a33147719b
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20220617/202206172146.gg9GL71Z-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/e58f821bf9b04f502947d46edce5e694afba26ca
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Oleksandr-Mazur/net-marvell-prestera-add-MDB-offloading-support/20220617-181737
        git checkout e58f821bf9b04f502947d46edce5e694afba26ca
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/net/ethernet/marvell/prestera/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/marvell/prestera/prestera_switchdev.c: In function 'prestera_mdb_flush_bridge_port':
>> drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:1776:36: warning: variable 'mdb' set but not used [-Wunused-but-set-variable]
    1776 |         struct prestera_mdb_entry *mdb;
         |                                    ^~~


vim +/mdb +1776 drivers/net/ethernet/marvell/prestera/prestera_switchdev.c

  1769	
  1770	static void
  1771	prestera_mdb_flush_bridge_port(struct prestera_bridge_port *br_port)
  1772	{
  1773		struct prestera_br_mdb_port *br_mdb_port, *tmp_port;
  1774		struct prestera_br_mdb_entry *br_mdb, *br_mdb_tmp;
  1775		struct prestera_bridge *br_dev = br_port->bridge;
> 1776		struct prestera_mdb_entry *mdb;
  1777	
  1778		list_for_each_entry_safe(br_mdb, br_mdb_tmp, &br_dev->br_mdb_entry_list,
  1779					 br_mdb_entry_node) {
  1780			mdb = br_mdb->mdb;
  1781	
  1782			list_for_each_entry_safe(br_mdb_port, tmp_port,
  1783						 &br_mdb->br_mdb_port_list,
  1784						 br_mdb_port_node) {
  1785				prestera_mdb_port_del(br_mdb->mdb,
  1786						      br_mdb_port->br_port->dev);
  1787				prestera_br_mdb_port_del(br_mdb,  br_mdb_port->br_port);
  1788			}
  1789			prestera_br_mdb_entry_put(br_mdb);
  1790		}
  1791	}
  1792	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp