linux-kernel - Re: [PATCH 4/4] virtio-crypto: support ECDSA algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Jun 2022 22:40:36 +0800
From:   kernel test robot <lkp@...el.com>
To:     Lei He <helei.sig11@...edance.com>, herbert@...dor.apana.org.au,
        davem@...emloft.net, dhowells@...hat.com, mst@...hat.com
Cc:     kbuild-all@...ts.01.org, arei.gonglei@...wei.com,
        jasowang@...hat.com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, pizhenwei@...edance.com,
        helei.sig11@...edance.com, f4bug@...at.org, berrange@...hat.com
Subject: Re: [PATCH 4/4] virtio-crypto: support ECDSA algorithm

Hi Lei,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on herbert-cryptodev-2.6/master]
[also build test ERROR on herbert-crypto-2.6/master linus/master v5.19-rc2 next-20220617]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Lei-He/virtio-crypto-support-ECDSA-algorithm/20220617-151113
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220617/202206172202.d2j2nFUX-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/d335068e54f1217848445185702d75739116b1fe
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Lei-He/virtio-crypto-support-ECDSA-algorithm/20220617-151113
        git checkout d335068e54f1217848445185702d75739116b1fe
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   ld: drivers/crypto/virtio/virtio_crypto_akcipher_algs.o: in function `virtio_crypto_ecdsa_max_size':
>> drivers/crypto/virtio/virtio_crypto_akcipher_algs.c:602: undefined reference to `ecdsa_max_signature_size'


vim +602 drivers/crypto/virtio/virtio_crypto_akcipher_algs.c

   596	
   597	static unsigned int virtio_crypto_ecdsa_max_size(struct crypto_akcipher *tfm)
   598	{
   599		struct virtio_crypto_akcipher_ctx *ctx = akcipher_tfm_ctx(tfm);
   600		struct virtio_crypto_ecdsa_ctx *ecdsa_ctx = &ctx->ecdsa_ctx;
   601	
 > 602		return ecdsa_max_signature_size(ecdsa_ctx->curve);
   603	}
   604	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp