linux-kernel - Re: [PATCH] [RFC] Kbuild: change CONFIG_FRAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220617163702.fqyomgoknvinlq6u@pengutronix.de>
Date:   Fri, 17 Jun 2022 18:37:02 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        linux-kbuild@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Nathan Chancellor <nathan@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RFC] Kbuild: change CONFIG_FRAME_WARN for 32-bit

Hello Arnd,

your To: was empty, I wonder if that was on purpose?!

On Fri, Jun 17, 2022 at 05:08:53PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The introduction of CONFIG_GCC_PLUGIN_LATENT_ENTROPY raised the
> warning limit for 32-bit architectures to a much higher value in
> 2016. Initially this had no effect for Arm machines as their kernels
> tend to be cross-compiled, and the feature detection for the plugin did
> not work with common cross compilers.
> 
> I could not find the original regression report that led to the warning
> limit getting raised, but I have been unable to reproduce this with gcc-12
> and linux-5.18 -- all frame sizes appear to be be below the normal 1024
> byte limit on at least arm32 and i386.
> 
> However, the KASAN feature introduced later on does raise the frame size
> of a number of functions above the warning limit, in almost all cases to
> somewhere below 1280 bytes. The effect is that an arm allmodconfig build
> produces no warnings because of the check for the latent entropy plugin,
> but a normal KASAN based build with gcc does produce build warnings or
> failures when CONFIG_WERROR is set.
> 
> The 1280 byte limit is an arbitrary choice here, as it disables almost
> all warnings but leaves a few outliers that are probably better addressed
> with code changes. There are a number of functions that are just below the
> normal 1024 byte limit at the moment, and an extra 256 bytes for those
> is within the expectation, but more than that is probably an indication
> of a bad design or a real bug.
> 
> Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Cc: Masahiro Yamada <masahiroy@...nel.org>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: linux-kbuild@...r.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  lib/Kconfig.debug | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 3da5f9acb966..8a3afd837e99 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -387,9 +387,9 @@ endif # DEBUG_INFO
>  config FRAME_WARN
>  	int "Warn for stack frames larger than"
>  	range 0 8192
> -	default 2048 if GCC_PLUGIN_LATENT_ENTROPY
>  	default 2048 if PARISC
>  	default 1536 if (!64BIT && XTENSA)
> +	default 1280 if (!64BIT && KASAN_STACK)
>  	default 1024 if !64BIT
>  	default 2048 if 64BIT
>  	help

I wasn't aware this was configurable with a Kconfig symbol.

Thanks for addressing that issue, the reasoning looks good and right.
I just now noticed you explained your findings earlier in irc, only
found them because I digged my irc logs for my original report to you.

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)