linux-kernel - Re: [PATCH] dma-buf: deprecate DMABUF_SYSFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABdmKX2yD_UPUVvZEX3+Bi55eTW2=NDAxWLay1fRjGu4W0W1EA@mail.gmail.com>
Date:   Fri, 17 Jun 2022 11:05:28 -0700
From:   "T.J. Mercier" <tjmercier@...gle.com>
To:     Christian König <ckoenig.leichtzumerken@...il.com>
Cc:     linux-kernel@...r.kernel.org, linaro-mm-sig@...ts.linaro.org,
        dri-devel@...ts.freedesktop.org, linux-media@...r.kernel.org,
        kernel-team@...roid.com, Daniel Vetter <daniel.vetter@...ll.ch>,
        Greg Kroah-Hartman <gregkh@...gle.com>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH] dma-buf: deprecate DMABUF_SYSFS_STATS

On Fri, Jun 17, 2022 at 1:57 AM Christian König
<ckoenig.leichtzumerken@...il.com> wrote:
>
> Add a warning that this UAPI wasn't such a good idea and shouldn't be
> used by anybody.
>
> That should give us a better chance to remove it at some point and
> prevents others from running into the same issues.
>
> Signed-off-by: Christian König <christian.koenig@....com>
> ---
>  drivers/dma-buf/Kconfig | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
> index 541efe01abc7..e4dc53a36428 100644
> --- a/drivers/dma-buf/Kconfig
> +++ b/drivers/dma-buf/Kconfig
> @@ -75,7 +75,7 @@ menuconfig DMABUF_HEAPS
>           between drivers.
>
>  menuconfig DMABUF_SYSFS_STATS
> -       bool "DMA-BUF sysfs statistics"
> +       bool "DMA-BUF sysfs statistics (DEPRECATED)"
>         depends on DMA_SHARED_BUFFER
>         help
>            Choose this option to enable DMA-BUF sysfs statistics
> @@ -85,6 +85,10 @@ menuconfig DMABUF_SYSFS_STATS
>            statistics for the DMA-BUF with the unique inode number
>            <inode_number>.
>
> +          This option is deprecated and should sooner or later be removed.
> +          Android is the only user of this and it turned out that this resulted
> +          in quite some performance problems.
> +
>  source "drivers/dma-buf/heaps/Kconfig"
>
>  endmenu
> --
> 2.25.1
>
Reviewed-by: T.J. Mercier <tjmercier@...gle.com>