linux-kernel - Re: [PATCH] Fix use of uninitialized variable in rts5261_init_from_hw, when efuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YqzKrdI0JBORlptt@dev-arch.thelio-3990X>
Date:   Fri, 17 Jun 2022 11:40:45 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     HighW4y2H3ll <huzh@....edu>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix use of uninitialized variable in
 rts5261_init_from_hw, when efuse_valid == 1.

On Fri, Jun 17, 2022 at 12:47:55AM -0400, HighW4y2H3ll wrote:
> Signed-off-by: zhenghao hu <huzh@....edu>
> ---
>  drivers/misc/cardreader/rts5261.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/cardreader/rts5261.c b/drivers/misc/cardreader/rts5261.c
> index 749cc5a46d13..f22634b14dc8 100644
> --- a/drivers/misc/cardreader/rts5261.c
> +++ b/drivers/misc/cardreader/rts5261.c
> @@ -403,7 +403,7 @@ static void rts5261_init_from_hw(struct rtsx_pcr *pcr)
>  			setting_reg1 = PCR_SETTING_REG4;
>  			setting_reg2 = PCR_SETTING_REG5;
>  		}
> -	} else if (efuse_valid == 0) {
> +	} else {
>  		// default
>  		setting_reg1 = PCR_SETTING_REG1;
>  		setting_reg2 = PCR_SETTING_REG2;
> -- 
> 2.35.1
> 

I know Greg already replied but this has been fixed already [1]. Due to
a small snafu [2], it won't make 5.19-rc3 but I hope it will be fixed in
5.19-rc4.

[1]: https://git.kernel.org/gregkh/char-misc/c/bd476c1306ea989d6d9eb65295572e98d93edeb6
[2]: https://lore.kernel.org/CE205655-557F-486C-AF6A-099749208327@kroah.com/

Cheers,
Nathan