linux-kernel - Re: [PATCH 2/2] Documentation: Add a blurb about using scripts/git-send-email.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ilozp1j7.fsf@meer.lwn.net>
Date:   Fri, 17 Jun 2022 12:50:36 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Mario Limonciello <mario.limonciello@....com>,
        mario.limonciello@....com, linux-kernel@...r.kernel.org
Cc:     Joe Perches <joe@...ches.com>, linux-doc@...r.kernel.org
Subject: Re: [PATCH 2/2] Documentation: Add a blurb about using
 scripts/git-send-email.sh

Mario Limonciello <mario.limonciello@....com> writes:

> In the part of the documentation explaining about identifying maintainers
> mention the `scripts/git-send-email.sh` helper script.
>
> Suggested-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
>  Documentation/process/submitting-patches.rst | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

So if you used this script to send this series, I can already see a
problem; I have a 2/2 patch without having seen the script that you are
talking about.  Bringing in maintainers partway through a patch series
like this is not the best way to go.

> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index a1cb6280fbcf..039deed14c49 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -225,7 +225,10 @@ Select the recipients for your patch
>  ------------------------------------
>  
>  You should always copy the appropriate subsystem maintainer(s) on any patch
> -to code that they maintain; look through the MAINTAINERS file and the
> +to code that they maintain. A helper script is available in
> +./scripts/git-send-email.sh that can be used with git-send-email to automatically
> +findd the appropriate recipients for a patch.

Please run a spelling checker on your documentation changes.

> +Alternatively you may look through the MAINTAINERS file manually and the
>  source code revision history to see who those maintainers are.  The
>  script scripts/get_maintainer.pl can be very useful at this step (pass paths to
>  your patches as arguments to scripts/get_maintainer.pl).  If you cannot find a
> -- 
> 2.25.1

Thanks,

jon