linux-kernel - Re: [PATCH] soc: ti: pm33xx: Fix refcount leak in am33xx_pm_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Jun 2022 19:28:36 -0500
From:   Nishanth Menon <nm@...com>
To:     Miaoqian Lin <linmq006@...il.com>
CC:     Santosh Shilimkar <ssantosh@...nel.org>,
        Keerthy <j-keerthy@...com>, Tony Lindgren <tony@...mide.com>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] soc: ti: pm33xx: Fix refcount leak in am33xx_pm_rtc_setup

On 11:41-20220516, Miaoqian Lin wrote:
> of_find_node_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: 5a99ae0092fe ("soc: ti: pm33xx: AM437X: Add rtc_only with ddr in self-refresh support")

Trouble here is that the patch wont apply directly on this commit ->
So, when we pass this over to stable, it will fail for certain stable
kernels, you want to explicitly list the stables on which this should
apply to.

Documentation/process/stable-kernel-rules.rst and be explicit in the
rules here.

[...]

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D