linux-kernel - Re: [PATCH] rcu: Avoid strict QS reporting in NMI context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20220618145659.GM1790663@paulmck-ThinkPad-P17-Gen-1>
Date:   Sat, 18 Jun 2022 07:56:59 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     "Zhang, Qiang1" <qiang1.zhang@...el.com>
Cc:     Frederic Weisbecker <frederic@...nel.org>,
        "rcu@...r.kernel.org" <rcu@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rcu: Avoid strict QS reporting in NMI context

On Sat, Jun 18, 2022 at 12:15:23PM +0000, Zhang, Qiang1 wrote:
> Le sam. 18 juin 2022, 04:23, Zqiang <qiang1.zhang@...el.com<mailto:qiang1.zhang@...el.com>> a écrit :
> Avoid invoke rcu_report_qs_rdp() in NMI handlers, in NMI handlers,
> acquiring raw_spinlocks should be avoided, prevent NMI handlers
> from blocking(spin) unnecessarily.
> 
> This commit make rcu_read_unlock_strict() early return when in
> NMI context.
> 
> Signed-off-by: Zqiang <qiang1.zhang@...el.com<mailto:qiang1.zhang@...el.com>>
> ---
>  kernel/rcu/tree_plugin.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index dc78726b993f..e7a36e248a8a 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -821,7 +821,7 @@ void rcu_read_unlock_strict(void)
>  {
>         struct rcu_data *rdp;
> 
> -       if (irqs_disabled() || preempt_count() || !rcu_state.gp_kthread)
> +       if (in_nmi() || irqs_disabled() || preempt_count() || !rcu_state.gp_kthread)
> 
> >Doesn't preempt_count() imply in_nmi()?
> >
> 
> 
> 
> It looks like this, thanks Frederic
> 
> #define nmi_count()     (preempt_count() & NMI_MASK)
> #define in_nmi()                (nmi_count())
> 
> Hi Paul, sorry it’s my mistake.

Thank you both for catching this!

I clearly should not be reviewing incoming patches late on Friday
evening!

							Thanx, Paul

> >Thanks.
> 
>                 return;
>         rdp = this_cpu_ptr(&rcu_data);
>         rdp->cpu_no_qs.b.norm = false;
> --
> 2.25.1