linux-kernel - Re: [PATCH v8 2/5] arm64: dts: qcom: sc7180: Add quackingstick dts files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=V9RaRuvx+N1FXszA4vKJiUXhZfGcdEFXWPg+DGq=p9kw@mail.gmail.com>
Date:   Fri, 17 Jun 2022 17:15:50 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     "Joseph S. Barrera III" <joebar@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Alexandru M Stan <amstan@...omium.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v8 2/5] arm64: dts: qcom: sc7180: Add quackingstick dts files

Hi,

On Fri, Jun 17, 2022 at 4:40 PM Joseph S. Barrera III
<joebar@...omium.org> wrote:
>
> Quackingstick is a trogdor-based board. These dts files are copies from
> the downstream Chrome OS 5.4 kernel, but with downstream bits removed.
>
> Signed-off-by: Joseph S. Barrera III <joebar@...omium.org>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>

At this point enough things keep being broken that I'd rather you keep
my "Reviewed-by" tag off for now in the next version.


> ---
>
> (no changes since v7)
>
> Changes in v7:
>  - Incorporated changes from Stephen's "Simplify!" series.
>
> Changes in v5:
> - Removed extra newline
> - Added comment that compatible will be filled in per-board

Not a huge deal, but your version history is missing a mention about
incorporating the deletion of the usb_c1 node.

-Doug