[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220619134716.64292039@jic23-huawei>
Date: Sun, 19 Jun 2022 13:47:16 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Jagath Jog J <jagathjog1996@...il.com>
Cc: Andy Shevchenko <andy.shevchenko@...il.com>,
linux-iio <linux-iio@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 2/2] iio: accel: bma400: Add support for single and
double tap events
> >
> > ...
> >
> > > bool step_event_en;
> > > bool activity_event_en;
> > > unsigned int generic_event_en;
> > > + unsigned int tap_event_en;
> >
> > Should it be boolean? Or i.o.w. why does it need to be an unsigned int?
>
> tap_event_en is used as a bitmask. Bit 2 and 3 of tap_event_en
> are used to tell the state of the single and double tap events.
> For example bit 2 is used to indicate single tap is enabled or not.
>
> set_mask_bits() and FIELD_GET() is used to set and retrieve the
> required bit value so I used unsigned int.
Perhaps make that obvious by calling it
tap_event_en_bitmask ?
Powered by blists - more mailing lists