linux-kernel - Re: [PATCH v6 1/2] dt-bindings: Document ltrf216a light sensor bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8dedf7d8-4760-dedc-0b47-fcdb0d32a3d9@collabora.com>
Date:   Sun, 19 Jun 2022 18:27:15 +0530
From:   Shreeya Patel <shreeya.patel@...labora.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     lars@...afoo.de, robh+dt@...nel.org, Zhigang.Shi@...eon.com,
        krisman@...labora.com, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com, alvaro.soliverez@...labora.com,
        andy.shevchenko@...il.com, digetx@...il.com
Subject: Re: [PATCH v6 1/2] dt-bindings: Document ltrf216a light sensor
 bindings


On 19/06/22 18:04, Jonathan Cameron wrote:
> On Wed, 15 Jun 2022 19:21:29 +0530
> Shreeya Patel <shreeya.patel@...labora.com> wrote:
>
>> Add devicetree bindings for ltrf216a ambient light sensor.
>>
>> Signed-off-by: Shreeya Patel <shreeya.patel@...labora.com>
>> ---
>> Changes in v5
>>    - Remove deprecated string 'ltr' from the bindings.
>>
>> Changes in v3
>>    - Fix indentation in the example section
>>
>> Changes in v2
>>    - Take over the maintainership for the bindings
>>    - Add interrupt and power supply property in DT bindings
>>
>>   .../bindings/iio/light/liteon,ltrf216a.yaml   | 50 +++++++++++++++++++
>>   1 file changed, 50 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml b/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml
>> new file mode 100644
>> index 000000000000..f256ff2e744c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml
>> @@ -0,0 +1,50 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/iio/light/liteon,ltrf216a.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: LTRF216A Ambient Light Sensor
>> +
>> +maintainers:
>> +  - Shreeya Patel <shreeya.patel@...labora.com>
>> +
>> +description:
>> +  Ambient light sensing with an i2c interface.
>> +
>> +properties:
>> +  compatible:
>> +    const:
>> +      - liteon,ltrf216a
> I assume you figured this out from the build bot error.
>
> 	const: liteon,ltrf216a
>
> Please make sure to do what that message from Rob's bot says and test your bindings
> before sending v7.

Hi Jonathan,

Sorry for the noise, I wasn't seeing this error before when I tested it 
on my machine.
I just did a make clean and was able to see the error after that. I have 
fixed it now for v7.


Thanks,
Shreeya Patel

>
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  vdd-supply:
>> +    description: Regulator that provides power to the sensor.
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> +    i2c {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        light-sensor@53 {
>> +            compatible = "liteon,ltrf216a";
>> +            reg = <0x53>;
>> +            vdd-supply = <&vdd_regulator>;
>> +            interrupt-parent = <&gpio0>;
>> +            interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
>> +        };
>> +    };