linux-kernel - [bvanassche:block-bitwise-opf 15/15] drivers/block/paride/pd.c:487:10: warning: 12 enumeration values not handled in switch: 'REQ_OP_FLUSH', 'REQ_OP_DISCARD', 'REQ_OP_SECURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 19 Jun 2022 21:54:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     Bart Van Assche <bvanassche@....org>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: [bvanassche:block-bitwise-opf 15/15]
 drivers/block/paride/pd.c:487:10: warning: 12 enumeration values not handled
 in switch: 'REQ_OP_FLUSH', 'REQ_OP_DISCARD', 'REQ_OP_SECURE_ERASE'...

tree:   https://github.com/bvanassche/linux block-bitwise-opf
head:   031ccdd616b11c4e774e56aa7eae906188ab24cc
commit: 031ccdd616b11c4e774e56aa7eae906188ab24cc [15/15] block: Introduce the type blk_mq_opf_t
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220619/202206192107.iLLORMOz-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project af6d2a0b6825e71965f3e2701a63c239fa0ad70f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc cross compiling tool for clang build
        # apt-get install binutils-powerpc-linux-gnu
        # https://github.com/bvanassche/linux/commit/031ccdd616b11c4e774e56aa7eae906188ab24cc
        git remote add bvanassche https://github.com/bvanassche/linux
        git fetch --no-tags bvanassche block-bitwise-opf
        git checkout 031ccdd616b11c4e774e56aa7eae906188ab24cc
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/block/paride/pd.c:487:10: warning: 12 enumeration values not handled in switch: 'REQ_OP_FLUSH', 'REQ_OP_DISCARD', 'REQ_OP_SECURE_ERASE'... [-Wswitch]
           switch (req_op(pd_req)) {
                   ^~~~~~~~~~~~~~
   include/linux/blk-mq.h:200:21: note: expanded from macro 'req_op'
   #define req_op(req) (__force enum req_op)((req)->cmd_flags & REQ_OP_MASK)
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 warning generated.


vim +487 drivers/block/paride/pd.c

^1da177e4c3f41 Linus Torvalds    2005-04-16  484  
^1da177e4c3f41 Linus Torvalds    2005-04-16  485  static enum action do_pd_io_start(void)
^1da177e4c3f41 Linus Torvalds    2005-04-16  486  {
aebf526b53aea1 Christoph Hellwig 2017-01-31 @487  	switch (req_op(pd_req)) {
aebf526b53aea1 Christoph Hellwig 2017-01-31  488  	case REQ_OP_DRV_IN:
^1da177e4c3f41 Linus Torvalds    2005-04-16  489  		phase = pd_special;
^1da177e4c3f41 Linus Torvalds    2005-04-16  490  		return pd_special();
aebf526b53aea1 Christoph Hellwig 2017-01-31  491  	case REQ_OP_READ:
aebf526b53aea1 Christoph Hellwig 2017-01-31  492  	case REQ_OP_WRITE:
83096ebf1263b2 Tejun Heo         2009-05-07  493  		pd_block = blk_rq_pos(pd_req);
83096ebf1263b2 Tejun Heo         2009-05-07  494  		pd_count = blk_rq_cur_sectors(pd_req);
f3fa33acca9f00 Christoph Hellwig 2021-11-26  495  		if (pd_block + pd_count > get_capacity(pd_req->q->disk))
^1da177e4c3f41 Linus Torvalds    2005-04-16  496  			return Fail;
83096ebf1263b2 Tejun Heo         2009-05-07  497  		pd_run = blk_rq_sectors(pd_req);
b4f42e2831ff9b Jens Axboe        2014-04-10  498  		pd_buf = bio_data(pd_req->bio);
^1da177e4c3f41 Linus Torvalds    2005-04-16  499  		pd_retries = 0;
aebf526b53aea1 Christoph Hellwig 2017-01-31  500  		if (req_op(pd_req) == REQ_OP_READ)
^1da177e4c3f41 Linus Torvalds    2005-04-16  501  			return do_pd_read_start();
^1da177e4c3f41 Linus Torvalds    2005-04-16  502  		else
^1da177e4c3f41 Linus Torvalds    2005-04-16  503  			return do_pd_write_start();
^1da177e4c3f41 Linus Torvalds    2005-04-16  504  	}
^1da177e4c3f41 Linus Torvalds    2005-04-16  505  	return Fail;
^1da177e4c3f41 Linus Torvalds    2005-04-16  506  }
^1da177e4c3f41 Linus Torvalds    2005-04-16  507  

:::::: The code at line 487 was first introduced by commit
:::::: aebf526b53aea164508730427597d45f3e06b376 block: fold cmd_type into the REQ_OP_ space

:::::: TO: Christoph Hellwig <hch@....de>
:::::: CC: Jens Axboe <axboe@...com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp