linux-kernel - Re: [PATCH -next] scsi: ufs: ufs-mediatek: Fix build error and type unmatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54053ba2b6ca09658a9c360397593a286446c06f.camel@mediatek.com>
Date:   Sun, 19 Jun 2022 22:11:27 +0800
From:   Stanley Chu <stanley.chu@...iatek.com>
To:     Ren Zhijie <renzhijie2@...wei.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <matthias.bgg@...il.com>,
        <powen.kao@...iatek.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH -next] scsi: ufs: ufs-mediatek: Fix build error and type
 unmatch

On Sun, 2022-06-19 at 19:54 +0800, Ren Zhijie wrote:
> If CONFIG_PM_SLEEP is not set.
> 
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-, will be failed,
> like this:
> 
> drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_vreg_fix_vcc’:
> drivers/ufs/host/ufs-mediatek.c:688:46: warning: format ‘%u’ expects
> argument of type ‘unsigned int’, but argument 4 has type ‘long
> unsigned int’ [-Wformat=]
>     snprintf(vcc_name, MAX_VCC_NAME, "vcc-opt%u", res.a1);
>                                              ~^   ~~~~~~
>                                              %lu
> drivers/ufs/host/ufs-mediatek.c: In function
> ‘ufs_mtk_system_suspend’:
> drivers/ufs/host/ufs-mediatek.c:1371:8: error: implicit declaration
> of function ‘ufshcd_system_suspend’; did you mean
> ‘ufs_mtk_system_suspend’? [-Werror=implicit-function-declaration]
>   ret = ufshcd_system_suspend(dev);
>         ^~~~~~~~~~~~~~~~~~~~~
>         ufs_mtk_system_suspend
> drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_system_resume’:
> drivers/ufs/host/ufs-mediatek.c:1386:9: error: implicit declaration
> of function ‘ufshcd_system_resume’; did you mean
> ‘ufs_mtk_system_resume’? [-Werror=implicit-function-declaration]
>   return ufshcd_system_resume(dev);
>          ^~~~~~~~~~~~~~~~~~~~
>          ufs_mtk_system_resume
> cc1: some warnings being treated as errors
> 
> The declaration of func "ufshcd_system_suspend()" is depended on
> CONFIG_PM_SLEEP, so the function wrapper "ufs_mtk_system_suspend()"
> should warpped by CONFIG_PM_SLEEP too.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: 3fd23b8dfb54("scsi: ufs: ufs-mediatek: Fix the timing of
> configuring device regulators")
> Signed-off-by: Ren Zhijie <renzhijie2@...wei.com>

Thanks for the fix!

Reviewed-by: Stanley Chu <stanley.chu@...iatek.com>